Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/synchronizer.js

Issue 6341149593698304: Issue 301 - Change for each to for .. of .. in lib/ (Closed)
Patch Set: Created April 10, 2014, 5:02 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/sync.js ('k') | lib/ui.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/synchronizer.js
===================================================================
--- a/lib/synchronizer.js
+++ b/lib/synchronizer.js
@@ -93,17 +93,17 @@ let Synchronizer = exports.Synchronizer
/**
* Yields Downloadable instances for all subscriptions that can be downloaded.
*/
_getDownloadables: function()
{
if (!Prefs.subscriptions_autoupdate)
return;
- for each (let subscription in FilterStorage.subscriptions)
+ for (let subscription of FilterStorage.subscriptions)
{
if (subscription instanceof DownloadableSubscription)
yield this._getDownloadable(subscription, false);
}
},
/**
* Creates a Downloadable instance for a subscription.
@@ -250,17 +250,17 @@ let Synchronizer = exports.Synchronizer
subscription.requiredVersion = minVersion;
if (Services.vc.compare(minVersion, addonVersion) > 0)
subscription.upgradeRequired = true;
}
// Process filters
lines.shift();
let filters = [];
- for each (let line in lines)
+ for (let line of lines)
{
line = Filter.normalize(line);
if (line)
filters.push(Filter.fromText(line));
}
FilterStorage.updateSubscriptionFilters(subscription, filters);
« no previous file with comments | « lib/sync.js ('k') | lib/ui.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld