Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: sitescripts/extensions/bin/updateUpdateManifests.py

Issue 6349778342379520: Issue 1048 - Fix Android update manifest format (Closed)
Patch Set: Remove pointless del, don't hard code basename Created Sept. 19, 2014, 2:25 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sitescripts/extensions/bin/updateUpdateManifests.py
===================================================================
--- a/sitescripts/extensions/bin/updateUpdateManifests.py
+++ b/sitescripts/extensions/bin/updateUpdateManifests.py
@@ -45,7 +45,9 @@
return {
'revision': revision,
+ 'version': version,
'minSdkVersion': get_min_sdk_version(repo, version),
+ 'basename': os.path.basename(repo.repository)
}
elif repo.type == 'safari':
metadata = repo.readMetadata(version)
@@ -104,7 +106,13 @@
if repoType == 'android':
newManifestPath = get_config().get("extensions",
"androidNewUpdateManifestPath")
- writeLibabpUpdateManifest(newManifestPath, extensions[repoType])
+ updates = {}
+ for extension in extensions[repoType]:
+ updates[extension['basename']] = {
+ 'version': extension['version'],
+ 'url': extension['updateURL']
+ }
+ writeLibabpUpdateManifest(newManifestPath, updates)
template = get_template(get_config().get('extensions', '%sUpdateManifest' % repoType))
template.stream({'extensions': extensions[repoType]}).dump(manifestPath)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld