Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: html/static/js/settings.js

Issue 6353703170736128: Issue 1112 - Properly use polyfills in firstrun and settings pages (Closed)
Left Patch Set: Created July 23, 2014, 12:33 p.m.
Right Patch Set: Keeping the 'false' parameter Created July 23, 2014, 12:47 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « html/static/js/firstRun.js ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 "use strict"; 1 "use strict";
2 2
3 (function() 3 (function()
4 { 4 {
5 function init() 5 function init()
6 { 6 {
7 var manageButton = document.getElementById("manageExceptions"); 7 var manageButton = document.getElementById("manageExceptions");
8 manageButton.addEventListener("click", toggleManage); 8 manageButton.addEventListener("click", toggleManage, false);
Felix Dahlke 2014/07/23 12:45:17 Might keep the false too.
9 } 9 }
10 10
11 function toggleManage(ev) 11 function toggleManage(ev)
12 { 12 {
13 var exceptions = document.getElementById("exceptions"); 13 var exceptions = document.getElementById("exceptions");
14 14
15 if (exceptions.getAttribute("class")) 15 if (exceptions.getAttribute("class"))
16 exceptions.removeAttribute("class"); 16 exceptions.removeAttribute("class");
17 else 17 else
18 exceptions.setAttribute("class", "visible"); 18 exceptions.setAttribute("class", "visible");
19 19
20 // IE6-only 20 // IE6-only
21 if (exceptions.getAttribute("className")) 21 if (exceptions.getAttribute("className"))
22 exceptions.removeAttribute("className"); 22 exceptions.removeAttribute("className");
23 else 23 else
24 exceptions.setAttribute("className", "visible"); 24 exceptions.setAttribute("className", "visible");
25 } 25 }
26 26
27 init(); 27 init();
28 })(); 28 })();
LEFTRIGHT

Powered by Google App Engine
This is Rietveld