Issue 2433 - Add promotional image to the Adblock Browser beta launch landing page (Infrastructure)

Related ticket:
https://issues.adblockplus.org/ticket/2433
Website:
http://codereview.adblockplus.org/6097796419551232/

[saroyanm, 2015-04-29 12:12:42]

Thomas this is just small addition, can you please have a look when you have
time.

[Thomas Greiner, 2015-04-29 12:18:42]

On 2015/04/29 12:12:42, saroyanm wrote:
> Thomas this is just small addition, can you please have a look when you have
> time.

Is there a reason why it has to be so large (1280x800)? Note that our promo
image for adblockplus.org is much smaller than that (540x305).
See
https://adblockplus.org/_override-static/global/global/img/adblockplus_promo.png

[saroyanm, 2015-04-29 12:26:17]

On 2015/04/29 12:18:42, Thomas Greiner wrote:
> On 2015/04/29 12:12:42, saroyanm wrote:
> > Thomas this is just small addition, can you please have a look when you have
> > time.
> 
> Is there a reason why it has to be so large (1280x800)? Note that our promo
> image for http://adblockplus.org is much smaller than that (540x305).
> See
>
https://adblockplus.org/_override-static/global/global/img/adblockplus_promo.png

According to FB best practices it would be nice to have images that are at least
1200 x 630 pixels for the best display:
https://developers.facebook.com/docs/sharing/best-practices#images

[Thomas Greiner, 2015-04-29 12:48:57]

On 2015/04/29 12:26:17, saroyanm wrote:
> On 2015/04/29 12:18:42, Thomas Greiner wrote:
> > On 2015/04/29 12:12:42, saroyanm wrote:
> > > Thomas this is just small addition, can you please have a look when you
have
> > > time.
> > 
> > Is there a reason why it has to be so large (1280x800)? Note that our promo
> > image for http://adblockplus.org is much smaller than that (540x305).
> > See
> >
>
https://adblockplus.org/_override-static/global/global/img/adblockplus_promo.png
> 
> According to FB best practices it would be nice to have images that are at
least
> 1200 x 630 pixels for the best display:
> https://developers.facebook.com/docs/sharing/best-practices#images

Ok, but it'll still be displayed at around 470x246 (at least on my screen) at
which size the footnote as well as the BETA label are not legible at all. While
the image size can stay as it is right now since yours is a valid argument, the
image should still be optimized for situations when it's being downscaled to
half of its size.

[saroyanm, 2015-04-29 12:52:40]

On 2015/04/29 12:48:57, Thomas Greiner wrote:
> On 2015/04/29 12:26:17, saroyanm wrote:
> > On 2015/04/29 12:18:42, Thomas Greiner wrote:
> > > On 2015/04/29 12:12:42, saroyanm wrote:
> > > > Thomas this is just small addition, can you please have a look when you
> have
> > > > time.
> > > 
> > > Is there a reason why it has to be so large (1280x800)? Note that our
promo
> > > image for http://adblockplus.org is much smaller than that (540x305).
> > > See
> > >
> >
>
https://adblockplus.org/_override-static/global/global/img/adblockplus_promo.png
> > 
> > According to FB best practices it would be nice to have images that are at
> least
> > 1200 x 630 pixels for the best display:
> > https://developers.facebook.com/docs/sharing/best-practices#images
> 
> Ok, but it'll still be displayed at around 470x246 (at least on my screen) at
> which size the footnote as well as the BETA label are not legible at all.
While
> the image size can stay as it is right now since yours is a valid argument,
the
> image should still be optimized for situations when it's being downscaled to
> half of its size.

Fare enough, will align with Christiane and update the image.

[saroyanm, 2015-04-29 13:48:51]

Patch Set 2 : Optimized promo image

[Thomas Greiner, 2015-04-29 15:32:01]

LGTM