Issue 301 - adblockplustests: Use for (.. of ..)

chrome/content/tests/filterListener.js

 (function()
 {
   module("Filter listener", {
     setup: function()
     {
       prepareFilterComponents.call(this, true);
       preparePrefs.call(this);
 
       FilterStorage.addSubscription(Subscription.fromURL("~fl~"));
       FilterStorage.addSubscription(Subscription.fromURL("~wl~"));
       FilterStorage.addSubscription(Subscription.fromURL("~eh~"));
 
       Subscription.fromURL("~fl~").defaults = ["blocking"];
       Subscription.fromURL("~wl~").defaults = ["whitelist"];
       Subscription.fromURL("~eh~").defaults = ["elemhide"];
     },
     teardown: function()
     {
       restoreFilterComponents.call(this);
       restorePrefs.call(this);
     }
   });
 
   function checkKnownFilters(text, expected)
   {
     let result = {};
-    for each (let type in ["blacklist", "whitelist"])
+    for (let type of ["blacklist", "whitelist"])
     {
       let matcher = defaultMatcher[type]
       let filters = [];
       for (let keyword in matcher.filterByKeyword)
       {
         let list = matcher.filterByKeyword[keyword];
         for (let i = 0; i < list.length; i++)
         {
           let filter = list[i];
           equal(matcher.getKeywordForFilter(filter), keyword, "Keyword of filter " + filter.text);
           filters.push(filter.text);
         }
       }
       result[type] = filters;
     }
 
     let ElemHideGlobal = getModuleGlobal("elemHide");
     result.elemhide = [];
     for (let key in ElemHideGlobal.filterByKey)
       result.elemhide.push(ElemHideGlobal.filterByKey[key].text);
 
     result.elemhideexception = [];
     for (let selector in ElemHideGlobal.exceptions)
     {
       let list = ElemHideGlobal.exceptions[selector];
       for (let i = 0; i < list.length; i++)
         result.elemhideexception.push(list[i].text);
     }
 
-    for each (let type in ["blacklist", "whitelist", "elemhide", "elemhideexception"])
+    for (let type of ["blacklist", "whitelist", "elemhide", "elemhideexception"])
       if (!(type in expected))
         expected[type] = [];
 
     deepEqual(result, expected, text);
   }
 
   test("Adding and removing filters", function()
   {
     let filter1 = Filter.fromText("filter1");
     let filter2 = Filter.fromText("@@filter2");
@@ skipping 176 matching lines @@
     subscription3.disabled = true;
     checkKnownFilters("disable exception rules", {blacklist: [filter1.text, filter3.text], whitelist: [filter2.text]});
 
     FilterStorage.removeSubscription(subscription4);
     checkKnownFilters("remove subscription from the list", {blacklist: [filter1.text]});
 
     subscription3.disabled = false;
     checkKnownFilters("enable exception rules", {blacklist: [filter1.text], whitelist: [filter2.text]});
   });
 })();