Issue 1148 - ABP on chrome blocks ads but IE doesnt

src/plugin/PluginFilter.cpp

 #include "PluginStdAfx.h"
 
 #include "PluginFilter.h"
 #include "PluginSettings.h"
 #include "PluginClient.h"
 #include "PluginClientFactory.h"
 #include "PluginMutex.h"
 #include "PluginSettings.h"
 #include "PluginSystem.h"
 #include "PluginClass.h"
 #include "mlang.h"
 
 #include "..\shared\CriticalSection.h"
+#include "..\shared\Utils.h"
 
 
 // The filters are described at http://adblockplus.org/en/filters
 
 static CriticalSection s_criticalSectionFilterMap;
 
+namespace
+{
+  // Returns attribute value and the bool flag which indicates whether the attribute is found.
+  // For the cases like <some-tag on-some-event="do();"/> IE returns the value of 'on-some-event'
+  // attribute as 'function(event){\ndo();\n}'. Our filters are not designed for such
+  // transformations, so this method retrives the value of (body) of /^.*?\{(body)\}$/ as well.
+  std::pair<std::wstring, bool> GetHtmlElementAttribute(IHTMLElement& htmlElement, const ATL::CComBSTR& attributeName)
+  {
+    std::pair<std::wstring, bool> retResult;
+    retResult.second = false;
+    ATL::CComVariant vAttr;
+    // Performs a property search that is not case-sensitive,
+    // and returns an interpolated value if the property is found.
+    LONG flags = 0;
+    if (FAILED(htmlElement.getAttribute(attributeName, flags, &vAttr)))
+    {
+      return retResult;
+    }
+    // we set that attribute found but it's not necessary that we can retrieve its value
+    retResult.second = true;
+    if (vAttr.vt == VT_BSTR && vAttr.bstrVal)
+    {
+      retResult.first.assign(vAttr.bstrVal);
+    }
+    else if (vAttr.vt == VT_I4)
+    {
+      retResult.first = std::to_wstring(vAttr.iVal);
+    }
+    else if (vAttr.vt == VT_DISPATCH)
+    {
+      wchar_t* toStringMethod = L"toString";
+      DISPID methodId = 0;
+      if (FAILED(vAttr.pdispVal->GetIDsOfNames(/*must be null iid*/IID_NULL, &toStringMethod,
+        /*cNames*/1, LOCALE_SYSTEM_DEFAULT, &methodId)))
+      {
+        return retResult;
+      }
+      ATL::CComVariant variantFunctionAsString; // result of IDispatch::Invoke
+      DISPID dispidNamed = DISPATCH_METHOD | DISPATCH_PROPERTYGET;
+      DISPPARAMS dispparams;
+      dispparams.rgvarg = &variantFunctionAsString;
+      dispparams.cArgs = 1;
+      dispparams.cNamedArgs = 1;
+      dispparams.rgdispidNamedArgs = &dispidNamed;
+      UINT ArgErr = 0;
+      if (FAILED(vAttr.pdispVal->Invoke(methodId, /*must be null iid*/IID_NULL,
+        LOCALE_SYSTEM_DEFAULT, dispidNamed, &dispparams, &variantFunctionAsString, /*exception info*/nullptr,
+        &ArgErr)))
+      {
+        return retResult;
+      }
+      if (variantFunctionAsString.vt != VT_BSTR)
+      {
+        return retResult;
+      }
+      std::wstring functionAsString = variantFunctionAsString.bstrVal;
+      auto bodyBeginsAt = functionAsString.find(L'{');
+      if (bodyBeginsAt == std::wstring::npos)
+      {
+        return retResult;
+      }
+      // eat spaces
+      while (::iswspace(functionAsString[++bodyBeginsAt]));
+      auto bodyEndsAt = functionAsString.rfind(L'}');
+      if (bodyEndsAt == std::wstring::npos || bodyEndsAt < bodyBeginsAt)
+      {
+        return retResult;
+      }
+      // eat spaces
+      while(::iswspace(functionAsString[--bodyEndsAt]));
+      retResult.first = functionAsString.substr(bodyBeginsAt, bodyEndsAt - bodyBeginsAt + 1);
+    }
+    return retResult;
+  }
+}
+
 // ============================================================================
 // CFilterElementHideAttrSelector
 // ============================================================================
 
 CFilterElementHideAttrSelector::CFilterElementHideAttrSelector() : m_type(TYPE_NONE), m_pos(POS_NONE), m_bstrAttr(NULL)
 {
 }
 
 CFilterElementHideAttrSelector::CFilterElementHideAttrSelector(const CFilterElementHideAttrSelector& filter)
 {
@@ skipping 235 matching lines @@
       }
       if (!foundMatch)
       {
         return false;
       }
     }
   }
   if (!m_tag.IsEmpty())
   {
     CComBSTR tagName;
+    hr = pEl->get_tagName(&tagName);
     tagName.ToLower();
-    hr = pEl->get_tagName(&tagName);
     if ((hr != S_OK) || (tagName != CComBSTR(m_tag)))
     {
       return false;
     }
   }
 
   // Check attributes
   for (std::vector<CFilterElementHideAttrSelector>::const_iterator attrIt = m_attributeSelectors.begin(); 
         attrIt != m_attributeSelectors.end(); ++ attrIt)
   {
-    CString value;
+    ATL::CString value;
     bool attrFound = false;
     if (attrIt->m_type == CFilterElementHideAttrType::STYLE)
     {
       CComPtr<IHTMLStyle> pStyle;
       if (SUCCEEDED(pEl->get_style(&pStyle)) && pStyle)
       {
         CComBSTR bstrStyle;
 
         if (SUCCEEDED(pStyle->get_cssText(&bstrStyle)) && bstrStyle)
         {
@@ skipping 14 matching lines @@
     }
     else if (attrIt->m_type == CFilterElementHideAttrType::ID)
     {
       CComBSTR bstrId;
       if (SUCCEEDED(pEl->get_id(&bstrId)) && bstrId)
       {
         value = bstrId;
         attrFound = true;
       }
     }
-    else 
+    else
     {
-      CComVariant vAttr;
-      if (SUCCEEDED(pEl->getAttribute(attrIt->m_bstrAttr, 0, &vAttr)))
+      auto attribute = GetHtmlElementAttribute(*pEl, attrIt->m_bstrAttr);
+      if (attrFound = attribute.second)
       {
-        attrFound = true;
-        if (vAttr.vt == VT_BSTR)
-        {
-          value = vAttr.bstrVal;
-        }
-        else if (vAttr.vt == VT_I4)
-        {
-          value.Format(L"%u", vAttr.iVal);
-        }
+        value = ToCString(attribute.first);
       }
     }
 
     if (attrFound)
     {
       if (attrIt->m_pos == CFilterElementHideAttrPos::EXACT)
       {
         // TODO: IE rearranges the style attribute completely. Figure out if anything can be done about it.
         if (value != attrIt->m_value)
           return false;
@@ skipping 82 matching lines @@
   m_contentMapText[CFilter::contentTypeSubdocument] = "SUBDOCUMENT";
   m_contentMapText[CFilter::contentTypeStyleSheet] = "STYLESHEET";
   m_contentMapText[CFilter::contentTypeXmlHttpRequest] = "XMLHTTPREQUEST";
 
   ClearFilters(); 
 }
 
 
 bool CPluginFilter::AddFilterElementHide(CString filterText)
 {
-
-
   DEBUG_FILTER("Input: " + filterText + " filterFile" + filterFile);
-
-  CriticalSection::Lock filterEngineLock(s_criticalSectionFilterMap);    
+  CriticalSection::Lock filterEngineLock(s_criticalSectionFilterMap);
   {
-
     CString filterString  = filterText;
     // Create filter descriptor
     std::auto_ptr<CFilterElementHide> filter;
 
     CString wholeFilterString = filterString;
     wchar_t separatorChar;
     do
     {
       int chunkEnd = filterText.FindOneOf(L"+>");
       if (chunkEnd > 0)
       {
         separatorChar = filterText.GetAt(chunkEnd);
       }
       else
       {
         chunkEnd = filterText.GetLength();
         separatorChar = L'\0';
       }
 
       CString filterChunk = filterText.Left(chunkEnd).TrimRight();
       std::auto_ptr<CFilterElementHide> filterParent(filter);
 
-      filter.reset(new CFilterElementHide(filterChunk));       
+      filter.reset(new CFilterElementHide(filterChunk));
 
       if (filterParent.get() != 0)
       {
         filter->m_predecessor.reset(filterParent.release());
       }
 
       if (separatorChar != L'\0') // complex selector
       {
         filterText = filterText.Mid(chunkEnd + 1).TrimLeft();
         if (separatorChar == '+')
@@ skipping 34 matching lines @@
     id = bstrId;
   }
 
   CString classNames;
   CComBSTR bstrClassNames;
   if (SUCCEEDED(pEl->get_className(&bstrClassNames)) && bstrClassNames)
   {
     classNames = bstrClassNames;
   }
 
-  CriticalSection::Lock filterEngineLock(s_criticalSectionFilterMap);    
+  CriticalSection::Lock filterEngineLock(s_criticalSectionFilterMap);
   {
     // Search tag/id filters
     if (!id.IsEmpty())
     {
       std::pair<TFilterElementHideTagsNamed::const_iterator, TFilterElementHideTagsNamed::const_iterator> idItEnum =
         m_elementHideTagsId.equal_range(std::make_pair(tagCString, id));
       for (TFilterElementHideTagsNamed::const_iterator idIt = idItEnum.first; idIt != idItEnum.second; idIt ++)
       {
         if (idIt->second.IsMatchFilterElementHide(pEl))
         {
@@ skipping 81 matching lines @@
 }
 
 bool CPluginFilter::LoadHideFilters(std::vector<std::wstring> filters)
 {
   ClearFilters();
   bool isRead = false;
   CPluginClient* client = CPluginClient::GetInstance();
 
   // Parse hide string
   int pos = 0;
-  CriticalSection::Lock filterEngineLock(s_criticalSectionFilterMap);    
+  CriticalSection::Lock filterEngineLock(s_criticalSectionFilterMap);
   {
     for (std::vector<std::wstring>::iterator it = filters.begin(); it < filters.end(); ++it)
     {
       CString filter((*it).c_str());
       // If the line is not commented out
       if (!filter.Trim().IsEmpty() && filter.GetAt(0) != '!' && filter.GetAt(0) != '[')
       {
         int filterType = 0;
 
         // See http://adblockplus.org/en/filters for further documentation
@@ skipping 71 matching lines @@
         CPluginDebug::DebugResultBlocking(type, srcCString, domain);
 #endif
     }
     return true;
   }
 #ifdef ENABLE_DEBUG_RESULT
   CPluginDebug::DebugResultIgnoring(type, srcCString, domain);
 #endif
   return false;
 }