Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6443935886999552: Issue 2444 - Configure default prefs in JSON (Closed)

Created:
May 1, 2015, 8:32 p.m. by Felix Dahlke
Modified:
May 4, 2015, 4:34 p.m.
Visibility:
Public.

Description

Issue 2444 - Configure default prefs in JSON

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -20 lines) Patch
M lib/prefs.js View 1 chunk +17 lines, -20 lines 1 comment Download

Messages

Total messages: 4
Felix Dahlke
Here's how the prefs.json would look like: { "defaults": { "currentVersion": "0.0", "enabled": true, "frameobjects": ...
May 1, 2015, 8:36 p.m. (2015-05-01 20:36:51 UTC) #1
Wladimir Palant
LGTM, we should get rid of the sync XMLHttpRequest later.
May 4, 2015, 2:01 p.m. (2015-05-04 14:01:59 UTC) #2
Felix Dahlke
Forgot to add Sebastian as a reviewer before.
May 4, 2015, 4:12 p.m. (2015-05-04 16:12:56 UTC) #3
Sebastian Noack
May 4, 2015, 4:27 p.m. (2015-05-04 16:27:48 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld