Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6468765319430144: Issue 417 - Reinitializing removed filter lists (Platform) (Closed)

Created:
May 26, 2014, 9:44 a.m. by Thomas Greiner
Modified:
May 27, 2014, 3:10 p.m.
Visibility:
Public.

Description

Also see http://codereview.adblockplus.org/5450822905233408/

Patch Set 1 #

Patch Set 2 : Moved check out of Core code #

Patch Set 3 : Fixed: Message also appeared on first-run #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M background.js View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M lib/filesystem/io.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Thomas Greiner
May 26, 2014, 1:33 p.m. (2014-05-26 13:33:21 UTC) #1
Wladimir Palant
As indicated in http://codereview.adblockplus.org/5450822905233408/, there are issues with this approach - the usual first-run code ...
May 26, 2014, 3:12 p.m. (2014-05-26 15:12:23 UTC) #2
Thomas Greiner
May 26, 2014, 5:45 p.m. (2014-05-26 17:45:40 UTC) #3
Wladimir Palant
LGTM
May 27, 2014, 6:45 a.m. (2014-05-27 06:45:53 UTC) #4
Thomas Greiner
I did some final testing and found that the warning message was also shown when ...
May 27, 2014, 12:14 p.m. (2014-05-27 12:14:54 UTC) #5
Wladimir Palant
May 27, 2014, 1:15 p.m. (2014-05-27 13:15:36 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld