Issue 2259 - Removed non-standard JavaScript code from Element Hiding Helper

lib/main.js

 /*
  * This Source Code is subject to the terms of the Mozilla Public License
  * version 2.0 (the "License"). You can obtain a copy of the License at
  * http://mozilla.org/MPL/2.0/.
  */
 
 Cu.import("resource://gre/modules/Services.jsm");
 
 let {Prefs} = require("prefs");
 let {WindowObserver} = require("windowObserver");
 let {WindowWrapper} = require("windowWrapper");
 
 // Check whether some preferences can still be found under their old locations
 Prefs.migrate("extensions.adblockplus.ehh-selectelement_key", "selectelement_key");
 Prefs.migrate("extensions.adblockplus.ehh.showhelp", "showhelp");
 
 // Window types to attach to
-let knownWindowTypes = Object.create(null);

[Wladimir Palant, 2015/04/01 19:01:14]

Better: Set(["navigator:browser", "mail:3pane", "mail:messageWindow"])

This will however require replacing |type in knownWindowTypes| by
|knownWindowTypes.has(type)| below.

[Sebastian Noack, 2015/04/02 07:19:47]

True.

-knownWindowTypes["navigator:browser"] = true;
-knownWindowTypes["mail:3pane"] = true;
-knownWindowTypes["mail:messageWindow"] = true;
+let knownWindowTypes = new Set(["navigator:browser", "mail:3pane", "mail:messageWindow"]);
 
 // Use random marker class
 let elementMarkerClass = null;
 {
   let rnd = [];
   let offset = "a".charCodeAt(0);
   for (let i = 0; i < 20; i++)
     rnd.push(offset + Math.random() * 26);
 
   elementMarkerClass = String.fromCharCode.apply(String, rnd);
@@ skipping 26 matching lines @@
     return;
 
   let overlay = event.target.responseXML.documentElement;
 
   // Initialization done, we can start up now
   require("inspectorObserver");
   new WindowObserver({
     applyToWindow: function(window)
     {
       let type = window.document.documentElement.getAttribute("windowtype");
-      if (!(type in knownWindowTypes) || window._ehhWrapper)
+      if (!knownWindowTypes.has(type) || window._ehhWrapper)
         return;
 
       window.document.documentElement.appendChild(overlay.cloneNode(true));
 
       let style = window.document.createProcessingInstruction("xml-stylesheet", 'class="elemhidehelper-node" href="chrome://elemhidehelper/skin/overlay.css" type="text/css"');
       window.document.insertBefore(style, window.document.firstChild);
 
       window._ehhWrapper = new WindowWrapper(window);
     },
 
     removeFromWindow: function(window)
     {
       if (!window._ehhWrapper)
         return;
 
       window._ehhWrapper.shutdown();
       delete window._ehhWrapper;
 
       let element = window.document.getElementById(overlay.getAttribute("id"));
       if (element)
         element.parentNode.removeChild(element);
 
       for (let child = window.document.firstChild; child; child = child.nextSibling)
         if (child.nodeType == child.PROCESSING_INSTRUCTION_NODE && child.data.indexOf("elemhidehelper-node") >= 0)
           child.parentNode.removeChild(child);
     }
   });
 }, false);
 request.send(null);