Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6523237609504768: Issue #276 - eliminate CString from CPluginMutex (Closed)

Created:
July 30, 2014, 5:56 p.m. by Eric
Modified:
Aug. 5, 2014, 1:05 p.m.
Visibility:
Public.

Description

Issue #276 - eliminate CString from CPluginMutex Replaced CString with std::wstring in CPluginMutex. Removed a bit of related dead code.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -29 lines) Patch
M src/plugin/PluginDebug.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/plugin/PluginMutex.h View 1 chunk +2 lines, -2 lines 2 comments Download
M src/plugin/PluginMutex.cpp View 4 chunks +11 lines, -8 lines 0 comments Download
M src/plugin/PluginSettings.cpp View 1 chunk +1 line, -18 lines 0 comments Download

Messages

Total messages: 5
Eric
July 30, 2014, 5:57 p.m. (2014-07-30 17:57:13 UTC) #1
Oleksandr
LGTM
Aug. 5, 2014, 11:34 a.m. (2014-08-05 11:34:01 UTC) #2
sergei
LGTM, except the new member name. http://codereview.adblockplus.org/6523237609504768/diff/5629499534213120/src/plugin/PluginMutex.h File src/plugin/PluginMutex.h (right): http://codereview.adblockplus.org/6523237609504768/diff/5629499534213120/src/plugin/PluginMutex.h#newcode13 src/plugin/PluginMutex.h:13: std::wstring system_name; Why ...
Aug. 5, 2014, 11:56 a.m. (2014-08-05 11:56:21 UTC) #3
Eric
http://codereview.adblockplus.org/6523237609504768/diff/5629499534213120/src/plugin/PluginMutex.h File src/plugin/PluginMutex.h (right): http://codereview.adblockplus.org/6523237609504768/diff/5629499534213120/src/plugin/PluginMutex.h#newcode13 src/plugin/PluginMutex.h:13: std::wstring system_name; On 2014/08/05 11:56:22, sergei wrote: > Why ...
Aug. 5, 2014, 12:56 p.m. (2014-08-05 12:56:18 UTC) #4
sergei
Aug. 5, 2014, 1:05 p.m. (2014-08-05 13:05:26 UTC) #5
OK

Powered by Google App Engine
This is Rietveld