Issue 2193 - Added notification opt-out (Firefox)

lib/ui.js

Index: lib/ui.js
===================================================================
--- a/lib/ui.js
+++ b/lib/ui.js
@@ -125,6 +125,14 @@
         this.value = Prefs.savestats;
       });
 
+      hideElement("adblockplus-shownotifications", !Prefs.notifications_showui);
+      setChecked("adblockplus-shownotifications", Prefs.notifications_ignoredcategories.indexOf("*") == -1);
+      addCommandHandler("adblockplus-shownotifications", function()
+      {
+        Notification.toggleIgnoreCategory("*");
+        this.value = (Prefs.notifications_ignoredcategories.indexOf("*") == -1);

[Wladimir Palant, 2015/06/26 13:13:09]

Nit: toggleIgnoreCategory() should really return the new value, not terribly
important however.

[Thomas Greiner, 2015/06/26 15:32:48]

Totally makes sense. I created #2727 for that now so that we can take care of it
later on.

+      });
+
       let hasAcceptableAds = FilterStorage.subscriptions.some((subscription) => subscription instanceof DownloadableSubscription &&
         subscription.url == Prefs.subscriptions_exceptionsurl);
       setChecked("adblockplus-acceptableAds", hasAcceptableAds);
@@ -587,10 +595,21 @@
     }.bind(this));
     addBrowserClickListener(window, this.onBrowserClick.bind(this, window));
 
-    window.document.getElementById("abp-notification-close").addEventListener("command", function(event)
+    let notificationPanel = window.document.getElementById("abp-notification");
+    notificationPanel.addEventListener("command", function(event)
     {
-      window.document.getElementById("abp-notification").hidePopup();
-    }, false);
+      switch (event.target.id)
+      {
+        case "abp-notification-close":
+          notificationPanel.classList.add("abp-closing");
+          break;
+        case "abp-notification-optout":
+          Notification.toggleIgnoreCategory("*", true);

[Wladimir Palant, 2015/06/26 13:13:09]

I'm not a huge fan of fallthrough in switch statements, it's very easy to miss.
At the very least we should adopt the suggestion from
https://wiki.mozilla.org/JavaScript:SpiderMonkey:Coding_Style and have /* FALL
THROUGH */ instead of the missing break statement here.

[Thomas Greiner, 2015/06/26 15:32:48]

Done. I guess it would make sense to add this to
https://adblockplus.org/en/coding-style#javascript then for future reference.

Also note Sebastian's comment on the Platform review:
https://codereview.adblockplus.org/29321084/diff/29321085/notification.js#new...
Therefore  I'd personally also add that "break" should always explicitly be set
in switch-statements.

+        case "abp-notification-hide":
+          notificationPanel.hidePopup();
+          break;
+      }
+    }, true);

[Wladimir Palant, 2015/06/26 13:13:09]

Why true? We don't usually add capturing event listeners.

[Thomas Greiner, 2015/06/26 15:32:48]

Done.

 
     // First-run actions?
     this.firstRunActions(window);
@@ -1563,10 +1582,12 @@
     let hasStatusBar = statusbarPosition;
     hideElement(prefix + "showintoolbar", !hasToolbar || prefix == "abp-toolbar-");
     hideElement(prefix + "showinstatusbar", !hasStatusBar);
+    hideElement(prefix + "shownotifications", !Prefs.notifications_showui);
     hideElement(prefix + "iconSettingsSeparator", (prefix == "abp-toolbar-" || !hasToolbar) && !hasStatusBar);
 
     setChecked(prefix + "showintoolbar", this.isToolbarIconVisible());
     setChecked(prefix + "showinstatusbar", Prefs.showinstatusbar);
+    setChecked(prefix + "shownotifications", Prefs.notifications_ignoredcategories.indexOf("*") == -1);
 
     let {Sync} = require("sync");
     let syncEngine = Sync.getEngine();
@@ -1954,7 +1975,8 @@
   ["abp-command-toggleshowinstatusbar", "command", UI.togglePref.bind(UI, "showinstatusbar")],
   ["abp-command-enable", "command", UI.togglePref.bind(UI, "enabled")],
   ["abp-command-contribute", "command", UI.openContributePage.bind(UI)],
-  ["abp-command-contribute-hide", "command", UI.hideContributeButton.bind(UI)]
+  ["abp-command-contribute-hide", "command", UI.hideContributeButton.bind(UI)],
+  ["abp-command-toggleshownotifications", "command", Notification.toggleIgnoreCategory.bind(Notification, "*", null)]
 ];
 
 onShutdown.add(function()