Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: ext/background.js

Issue 6528746257383424: Issue 1708 - Integrate first-run page changes in Chrome/Opera/Safari (Closed)
Patch Set: Rebased again Created Dec. 19, 2014, 3:45 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2014 Eyeo GmbH 3 * Copyright (C) 2006-2014 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 (function() 18 (function()
19 { 19 {
20 var nonEmptyPageMaps = {__proto__: null}; 20 var nonEmptyPageMaps = {__proto__: null};
21 var pageMapCounter = 0; 21 var pageMapCounter = 0;
22 22
23 var PageMap = ext.PageMap = function() 23 var PageMap = ext.PageMap = function()
24 { 24 {
25 this._map = {__proto__: null}; 25 this._map = Object.create(null);
Sebastian Noack 2014/12/19 17:57:53 Is that an unrelated change in a line you wouldn't
Wladimir Palant 2014/12/19 19:38:42 Yes, it's an unrelated change - I simply fixed thi
26 this._id = ++pageMapCounter; 26 this._id = ++pageMapCounter;
27 }; 27 };
28 PageMap.prototype = { 28 PageMap.prototype = {
29 _delete: function(id) 29 _delete: function(id)
30 { 30 {
31 delete this._map[id]; 31 delete this._map[id];
32 32
33 if (Object.keys(this._map).length == 0) 33 if (Object.keys(this._map).length == 0)
34 delete nonEmptyPageMaps[this._id]; 34 delete nonEmptyPageMaps[this._id];
35 }, 35 },
36 keys: function()
37 {
38 return Object.keys(this._map).map(ext._getPage);
39 },
36 get: function(page) 40 get: function(page)
37 { 41 {
38 return this._map[page._id]; 42 return this._map[page._id];
39 }, 43 },
40 set: function(page, value) 44 set: function(page, value)
41 { 45 {
42 this._map[page._id] = value; 46 this._map[page._id] = value;
43 nonEmptyPageMaps[this._id] = this; 47 nonEmptyPageMaps[this._id] = this;
44 }, 48 },
45 has: function(page) 49 has: function(page)
(...skipping 10 matching lines...) Expand all
56 this._delete(page._id); 60 this._delete(page._id);
57 } 61 }
58 }; 62 };
59 63
60 ext._removeFromAllPageMaps = function(pageId) 64 ext._removeFromAllPageMaps = function(pageId)
61 { 65 {
62 for (var pageMapId in nonEmptyPageMaps) 66 for (var pageMapId in nonEmptyPageMaps)
63 nonEmptyPageMaps[pageMapId]._delete(pageId); 67 nonEmptyPageMaps[pageMapId]._delete(pageId);
64 }; 68 };
65 })(); 69 })();
OLDNEW

Powered by Google App Engine
This is Rietveld