Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: jni/JniEventCallback.cpp

Issue 6606493159784448: New JNI bindings (Closed)
Patch Set: Style review fixes Created March 28, 2014, 11 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2014 Eyeo GmbH 3 * Copyright (C) 2006-2014 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #include "JniCallbacks.h" 18 #include "JniCallbacks.h"
19 19
20 AdblockPlus::Android::JniEventCallback::JniEventCallback(JNIEnv* env, jobject ca llbackObject) : 20 JniEventCallback::JniEventCallback(JNIEnv* env, jobject callbackObject)
21 JniCallbackBase(env, callbackObject) 21 : JniCallbackBase(env, callbackObject)
22 { 22 {
23 } 23 }
24 24
25 AdblockPlus::Android::JniEventCallback::~JniEventCallback() 25 JniEventCallback::~JniEventCallback()
26 { 26 {
27 } 27 }
28 28
29 void AdblockPlus::Android::JniEventCallback::Callback(AdblockPlus::JsValueList& params) 29 void JniEventCallback::Callback(AdblockPlus::JsValueList& params)
30 { 30 {
31 AdblockPlus::Android::JNIEnvAcquire env(GetJavaVM()); 31 JNIEnvAcquire env(GetJavaVM());
32 32
33 jclass clazz = env->GetObjectClass(GetCallbackObject()); 33 jclass clazz = env->GetObjectClass(GetCallbackObject());
34 jmethodID method = env->GetMethodID(clazz, "eventCallback", "(Ljava/util/List; )V"); 34 jmethodID method = env->GetMethodID(clazz, "eventCallback", "(Ljava/util/List; )V");
35 35
36 if (method) 36 if (method)
37 { 37 {
38 jobject jsList = AdblockPlus::Android::JniJsValueList2ArrayList(*env, params ); 38 jobject jsList = JniJsValueList2ArrayList(*env, params);
39 env->CallVoidMethod(GetCallbackObject(), method, jsList); 39 env->CallVoidMethod(GetCallbackObject(), method, jsList);
40 } 40 }
41 } 41 }
42 42
43 static jlong JNICALL JniCtor(JNIEnv* env, jclass clazz, jobject callbackObject) 43 static jlong JNICALL JniCtor(JNIEnv* env, jclass clazz, jobject callbackObject)
44 { 44 {
45 TRY 45 TRY
46 { 46 {
47 return AdblockPlus::Android::JniPtr2Long(new AdblockPlus::Android::JniEventC allback(env, callbackObject)); 47 return JniPtrToLong(new JniEventCallback(env, callbackObject));
48 } 48 }
49 CATCH_THROW_AND_RETURN(env, 0) 49 CATCH_THROW_AND_RETURN(env, 0)
50 } 50 }
51 51
52 static void JNICALL JniDtor(JNIEnv* env, jclass clazz, jlong ptr) 52 static void JNICALL JniDtor(JNIEnv* env, jclass clazz, jlong ptr)
53 { 53 {
54 delete AdblockPlus::Android::JniLong2TypePtr<AdblockPlus::Android::JniEventCal lback>(ptr); 54 delete JniLongToTypePtr<JniEventCallback>(ptr);
55 } 55 }
56 56
57 static JNINativeMethod methods[] = 57 static JNINativeMethod methods[] =
58 { 58 {
59 { (char*)"ctor", (char*)"(Ljava/lang/Object;)J", (void*)JniCtor }, 59 { (char*)"ctor", (char*)"(Ljava/lang/Object;)J", (void*)JniCtor },
60 { (char*)"dtor", (char*)"(J)V", (void*)JniDtor }, }; 60 { (char*)"dtor", (char*)"(J)V", (void*)JniDtor }
61 };
61 62
62 extern "C" JNIEXPORT void JNICALL Java_org_adblockplus_android_api_EventCallback _registerNatives(JNIEnv *env, jclass clazz) 63 extern "C" JNIEXPORT void JNICALL Java_org_adblockplus_android_api_EventCallback _registerNatives(JNIEnv *env, jclass clazz)
63 { 64 {
64 env->RegisterNatives(clazz, methods, sizeof(methods) / sizeof(methods[0])); 65 env->RegisterNatives(clazz, methods, sizeof(methods) / sizeof(methods[0]));
65 } 66 }
OLDNEW

Powered by Google App Engine
This is Rietveld