Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: jni/JniJsValue.cpp

Issue 6606493159784448: New JNI bindings (Closed)
Patch Set: Style review fixes Created March 28, 2014, 11 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2014 Eyeo GmbH 3 * Copyright (C) 2006-2014 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #include <AdblockPlus.h> 18 #include <AdblockPlus.h>
19 #include "Utils.h" 19 #include "Utils.h"
20 #include "JniJsValue.h" 20 #include "JniJsValue.h"
21 21
22 jobject AdblockPlus::Android::NewJniJsValue(JNIEnv* env, const AdblockPlus::JsVa luePtr& jsValue) 22 jobject NewJniJsValue(JNIEnv* env, const AdblockPlus::JsValuePtr& jsValue)
23 { 23 {
24 jclass clazz = env->FindClass(PKG("JsValue")); 24 jclass clazz = env->FindClass(PKG("JsValue"));
25 jmethodID ctor = env->GetMethodID(clazz, "<init>", "(J)V"); 25 jmethodID ctor = env->GetMethodID(clazz, "<init>", "(J)V");
26 jlong ptr = AdblockPlus::Android::JniPtr2Long(new AdblockPlus::JsValuePtr(jsVa lue)); 26 jlong ptr = JniPtrToLong(new AdblockPlus::JsValuePtr(jsValue));
27 return env->NewObject(clazz, ctor, ptr); 27 return env->NewObject(clazz, ctor, ptr);
28 } 28 }
29 29
30 AdblockPlus::JsValue* AdblockPlus::Android::JniGetJsValue(jlong ptr) 30 AdblockPlus::JsValue* JniGetJsValue(jlong ptr)
31 { 31 {
32 return AdblockPlus::Android::JniLong2TypePtr<AdblockPlus::JsValuePtr>(ptr)->ge t(); 32 return JniLongToTypePtr<AdblockPlus::JsValuePtr>(ptr)->get();
33 } 33 }
34 34
35 AdblockPlus::JsValuePtr& AdblockPlus::Android::JniGetJsValuePtr(jlong ptr) 35 AdblockPlus::JsValuePtr& JniGetJsValuePtr(jlong ptr)
36 { 36 {
37 return *AdblockPlus::Android::JniLong2TypePtr<AdblockPlus::JsValuePtr>(ptr); 37 return *JniLongToTypePtr<AdblockPlus::JsValuePtr>(ptr);
38 } 38 }
39 39
40 jobject AdblockPlus::Android::JniJsValueList2ArrayList(JNIEnv* env, AdblockPlus: :JsValueList& list) 40 jobject JniJsValueList2ArrayList(JNIEnv* env, AdblockPlus::JsValueList& list)
41 { 41 {
42 jobject arrayList = AdblockPlus::Android::NewJniArrayList(env); 42 jobject arrayList = NewJniArrayList(env);
43 43
44 for (AdblockPlus::JsValueList::iterator it = list.begin(), end = list.end(); i t != end; ++it) 44 for (AdblockPlus::JsValueList::iterator it = list.begin(), end = list.end(); i t != end; ++it)
45 { 45 {
46 AdblockPlus::Android::JniAddObjectToList(env, arrayList, AdblockPlus::Androi d::NewJniJsValue(env, *it)); 46 JniAddObjectToList(env, arrayList, NewJniJsValue(env, *it));
47 } 47 }
48 48
49 return arrayList; 49 return arrayList;
50 } 50 }
51 51
52 static jboolean JNICALL JniIsUndefined(JNIEnv* env, jclass clazz, jlong ptr) 52 static jboolean JNICALL JniIsUndefined(JNIEnv* env, jclass clazz, jlong ptr)
53 { 53 {
54 TRY 54 TRY
55 { 55 {
56 return AdblockPlus::Android::JniGetJsValue(ptr)->IsUndefined() ? JNI_TRUE : JNI_FALSE; 56 return JniGetJsValue(ptr)->IsUndefined() ? JNI_TRUE : JNI_FALSE;
57 } 57 }
58 CATCH_THROW_AND_RETURN(env, JNI_FALSE) 58 CATCH_THROW_AND_RETURN(env, JNI_FALSE)
59 } 59 }
60 60
61 static jboolean JNICALL JniIsNull(JNIEnv* env, jclass clazz, jlong ptr) 61 static jboolean JNICALL JniIsNull(JNIEnv* env, jclass clazz, jlong ptr)
62 { 62 {
63 TRY 63 TRY
64 { 64 {
65 return AdblockPlus::Android::JniGetJsValue(ptr)->IsNull() ? JNI_TRUE : JNI_F ALSE; 65 return JniGetJsValue(ptr)->IsNull() ? JNI_TRUE : JNI_FALSE;
66 } 66 }
67 CATCH_THROW_AND_RETURN(env, JNI_FALSE) 67 CATCH_THROW_AND_RETURN(env, JNI_FALSE)
68 } 68 }
69 69
70 static jboolean JNICALL JniIsString(JNIEnv* env, jclass clazz, jlong ptr) 70 static jboolean JNICALL JniIsString(JNIEnv* env, jclass clazz, jlong ptr)
71 { 71 {
72 TRY 72 TRY
73 { 73 {
74 return AdblockPlus::Android::JniGetJsValue(ptr)->IsString() ? JNI_TRUE : JNI _FALSE; 74 return JniGetJsValue(ptr)->IsString() ? JNI_TRUE : JNI_FALSE;
75 } 75 }
76 CATCH_THROW_AND_RETURN(env, JNI_FALSE) 76 CATCH_THROW_AND_RETURN(env, JNI_FALSE)
77 } 77 }
78 78
79 static jboolean JNICALL JniIsBoolean(JNIEnv* env, jclass clazz, jlong ptr) 79 static jboolean JNICALL JniIsBoolean(JNIEnv* env, jclass clazz, jlong ptr)
80 { 80 {
81 TRY 81 TRY
82 { 82 {
83 return AdblockPlus::Android::JniGetJsValue(ptr)->IsBool() ? JNI_TRUE : JNI_F ALSE; 83 return JniGetJsValue(ptr)->IsBool() ? JNI_TRUE : JNI_FALSE;
84 } 84 }
85 CATCH_THROW_AND_RETURN(env, JNI_FALSE) 85 CATCH_THROW_AND_RETURN(env, JNI_FALSE)
86 } 86 }
87 87
88 static jboolean JNICALL JniIsObject(JNIEnv* env, jclass clazz, jlong ptr) 88 static jboolean JNICALL JniIsObject(JNIEnv* env, jclass clazz, jlong ptr)
89 { 89 {
90 TRY 90 TRY
91 { 91 {
92 return AdblockPlus::Android::JniGetJsValue(ptr)->IsObject() ? JNI_TRUE : JNI _FALSE; 92 return JniGetJsValue(ptr)->IsObject() ? JNI_TRUE : JNI_FALSE;
93 } 93 }
94 CATCH_THROW_AND_RETURN(env, JNI_FALSE) 94 CATCH_THROW_AND_RETURN(env, JNI_FALSE)
95 } 95 }
96 96
97 static jboolean JNICALL JniIsArray(JNIEnv* env, jclass clazz, jlong ptr) 97 static jboolean JNICALL JniIsArray(JNIEnv* env, jclass clazz, jlong ptr)
98 { 98 {
99 TRY 99 TRY
100 { 100 {
101 return AdblockPlus::Android::JniGetJsValue(ptr)->IsArray() ? JNI_TRUE : JNI_ FALSE; 101 return JniGetJsValue(ptr)->IsArray() ? JNI_TRUE : JNI_FALSE;
102 } 102 }
103 CATCH_THROW_AND_RETURN(env, JNI_FALSE) 103 CATCH_THROW_AND_RETURN(env, JNI_FALSE)
104 } 104 }
105 105
106 static jboolean JNICALL JniIsFunction(JNIEnv* env, jclass clazz, jlong ptr) 106 static jboolean JNICALL JniIsFunction(JNIEnv* env, jclass clazz, jlong ptr)
107 { 107 {
108 TRY 108 TRY
109 { 109 {
110 return AdblockPlus::Android::JniGetJsValue(ptr)->IsFunction() ? JNI_TRUE : J NI_FALSE; 110 return JniGetJsValue(ptr)->IsFunction() ? JNI_TRUE : JNI_FALSE;
111 } 111 }
112 CATCH_THROW_AND_RETURN(env, JNI_FALSE) 112 CATCH_THROW_AND_RETURN(env, JNI_FALSE)
113 } 113 }
114 114
115 static jstring JNICALL JniAsString(JNIEnv* env, jclass clazz, jlong ptr) 115 static jstring JNICALL JniAsString(JNIEnv* env, jclass clazz, jlong ptr)
116 { 116 {
117 TRY 117 TRY
118 { 118 {
119 return env->NewStringUTF(AdblockPlus::Android::JniGetJsValue(ptr)->AsString( ).c_str()); 119 return env->NewStringUTF(JniGetJsValue(ptr)->AsString().c_str());
120 } 120 }
121 CATCH_THROW_AND_RETURN(env, 0) 121 CATCH_THROW_AND_RETURN(env, 0)
122 } 122 }
123 123
124 static jlong JNICALL JniAsLong(JNIEnv* env, jclass clazz, jlong ptr) 124 static jlong JNICALL JniAsLong(JNIEnv* env, jclass clazz, jlong ptr)
125 { 125 {
126 TRY 126 TRY
127 { 127 {
128 return static_cast<jlong>(AdblockPlus::Android::JniGetJsValue(ptr)->AsInt()) ; 128 return static_cast<jlong>(JniGetJsValue(ptr)->AsInt());
129 } 129 }
130 CATCH_THROW_AND_RETURN(env, 0) 130 CATCH_THROW_AND_RETURN(env, 0)
131 } 131 }
132 132
133 static jboolean JNICALL JniAsBoolean(JNIEnv* env, jclass clazz, jlong ptr) 133 static jboolean JNICALL JniAsBoolean(JNIEnv* env, jclass clazz, jlong ptr)
134 { 134 {
135 TRY 135 TRY
136 { 136 {
137 return AdblockPlus::Android::JniGetJsValue(ptr)->AsBool() ? JNI_TRUE : JNI_F ALSE; 137 return JniGetJsValue(ptr)->AsBool() ? JNI_TRUE : JNI_FALSE;
138 } 138 }
139 CATCH_THROW_AND_RETURN(env, JNI_FALSE) 139 CATCH_THROW_AND_RETURN(env, JNI_FALSE)
140 } 140 }
141 141
142 static jboolean JNICALL JniIsValid(JNIEnv* env, jclass clazz, jlong ptr) 142 static jboolean JNICALL JniIsValid(JNIEnv* env, jclass clazz, jlong ptr)
143 { 143 {
144 return AdblockPlus::Android::JniGetJsValue(ptr) ? JNI_TRUE : JNI_FALSE; 144 return JniGetJsValue(ptr) ? JNI_TRUE : JNI_FALSE;
145 } 145 }
146 146
147 static jobject JNICALL JniAsList(JNIEnv* env, jclass clazz, jlong ptr) 147 static jobject JNICALL JniAsList(JNIEnv* env, jclass clazz, jlong ptr)
148 { 148 {
149 TRY 149 TRY
150 { 150 {
151 AdblockPlus::JsValueList list = AdblockPlus::Android::JniGetJsValue(ptr)->As List(); 151 AdblockPlus::JsValueList list = JniGetJsValue(ptr)->AsList();
152 152
153 return AdblockPlus::Android::JniJsValueList2ArrayList(env, list); 153 return JniJsValueList2ArrayList(env, list);
154 } 154 }
155 CATCH_THROW_AND_RETURN(env, 0) 155 CATCH_THROW_AND_RETURN(env, 0)
156 } 156 }
157 157
158 static void JNICALL JniDtor(JNIEnv* env, jclass clazz, jlong ptr) 158 static void JNICALL JniDtor(JNIEnv* env, jclass clazz, jlong ptr)
159 { 159 {
160 delete AdblockPlus::Android::JniLong2TypePtr<AdblockPlus::JsValuePtr>(ptr); 160 delete JniLongToTypePtr<AdblockPlus::JsValuePtr>(ptr);
161 } 161 }
162 162
163 //std::vector<std::string> GetOwnPropertyNames() const; 163 //std::vector<std::string> GetOwnPropertyNames() const;
164 //JsValuePtr GetProperty(const std::string& name) const; 164 //JsValuePtr GetProperty(const std::string& name) const;
165 //void SetProperty(const std::string& name, const std::string& val); 165 //void SetProperty(const std::string& name, const std::string& val);
166 //void SetProperty(const std::string& name, int64_t val); 166 //void SetProperty(const std::string& name, int64_t val);
167 //void SetProperty(const std::string& name, bool val); 167 //void SetProperty(const std::string& name, bool val);
168 //void SetProperty(const std::string& name, JsValuePtr value); 168 //void SetProperty(const std::string& name, JsValuePtr value);
169 //void SetProperty(const std::string& name, const char* val); 169 //void SetProperty(const std::string& name, const char* val);
170 //inline void SetProperty(const std::string& name, int val); 170 //inline void SetProperty(const std::string& name, int val);
171 //std::string GetClass() const; 171 //std::string GetClass() const;
172 //JsValuePtr Call(const JsValueList& params = JsValueList(), AdblockPlus::JsValu ePtr thisPtr = AdblockPlus::JsValuePtr()) const; 172 //JsValuePtr Call(const JsValueList& params = JsValueList(), AdblockPlus::JsValu ePtr thisPtr = AdblockPlus::JsValuePtr()) const;
173 173
174 static JNINativeMethod methods[] = 174 static JNINativeMethod methods[] =
175 { 175 {
176 { (char*)"isUndefined", (char*)"(J)Z", (void*)JniIsUndefined }, 176 { (char*)"isUndefined", (char*)"(J)Z", (void*)JniIsUndefined },
177 { (char*)"isNull", (char*)"(J)Z", (void*)JniIsNull }, 177 { (char*)"isNull", (char*)"(J)Z", (void*)JniIsNull },
178 { (char*)"isString", (char*)"(J)Z", (void*)JniIsString }, 178 { (char*)"isString", (char*)"(J)Z", (void*)JniIsString },
179 { (char*)"isBoolean", (char*)"(J)Z", (void*)JniIsBoolean }, 179 { (char*)"isBoolean", (char*)"(J)Z", (void*)JniIsBoolean },
180 { (char*)"isObject", (char*)"(J)Z", (void*)JniIsObject }, 180 { (char*)"isObject", (char*)"(J)Z", (void*)JniIsObject },
181 { (char*)"isArray", (char*)"(J)Z", (void*)JniIsArray }, 181 { (char*)"isArray", (char*)"(J)Z", (void*)JniIsArray },
182 { (char*)"isFunction", (char*)"(J)Z", (void*)JniIsFunction }, 182 { (char*)"isFunction", (char*)"(J)Z", (void*)JniIsFunction },
183 { (char*)"asString", (char*)"(J)Ljava/lang/String;", (void*)JniAsString }, 183 { (char*)"asString", (char*)"(J)Ljava/lang/String;", (void*)JniAsString },
184 { (char*)"asLong", (char*)"(J)J", (void*)JniAsLong }, 184 { (char*)"asLong", (char*)"(J)J", (void*)JniAsLong },
185 { (char*)"asBoolean", (char*)"(J)Z", (void*)JniAsBoolean }, 185 { (char*)"asBoolean", (char*)"(J)Z", (void*)JniAsBoolean },
186 { (char*)"asList", (char*)"(J)Ljava/util/List;", (void*)JniAsList }, 186 { (char*)"asList", (char*)"(J)Ljava/util/List;", (void*)JniAsList },
187 { (char*)"isValid", (char*)"(J)Z", (void*)JniIsValid }, 187 { (char*)"isValid", (char*)"(J)Z", (void*)JniIsValid },
188 { (char*)"dtor", (char*)"(J)V", (void*)JniDtor }, }; 188 { (char*)"dtor", (char*)"(J)V", (void*)JniDtor }
189 };
189 190
190 extern "C" JNIEXPORT void JNICALL Java_org_adblockplus_android_api_JsValue_regis terNatives(JNIEnv *env, jclass clazz) 191 extern "C" JNIEXPORT void JNICALL Java_org_adblockplus_android_api_JsValue_regis terNatives(JNIEnv *env, jclass clazz)
191 { 192 {
192 env->RegisterNatives(clazz, methods, sizeof(methods) / sizeof(methods[0])); 193 env->RegisterNatives(clazz, methods, sizeof(methods) / sizeof(methods[0]));
193 } 194 }
OLDNEW

Powered by Google App Engine
This is Rietveld