Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Delta Between Two Patch Sets: src/org/adblockplus/android/JSEngine.java
Issue
6606493159784448
:
New JNI bindings (Closed)
Left Patch Set:
Created March 14, 2014, 11:32 a.m.
Right Patch Set: Removed TODO from AppInfo.
Created April 11, 2014, 1:28 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Added missing copyright header
Patch Set 3: Fixed wrong signature for getElementHidingSelectors.
Patch Set 4: Added LICENSE, moved callback impls into cpp files.
Patch Set 5: Cleaned up namespace usage in cpp files.
Patch Set 6: Style review fixes
Patch Set 7: Reuploaded full diff
Patch Set 8: Bug fix for global references (shadowing)
Patch Set 9: TRY, abpEngine, statics
Patch Set 10: Added missing empty lines after file comments
Patch Set 11: Changed AppInfo to use builder pattern.
Patch Set 12: Removed TODO from AppInfo.
Right:
Patch Set 1: None
Patch Set 2: Added missing copyright header
Patch Set 3: Fixed wrong signature for getElementHidingSelectors.
Patch Set 4: Added LICENSE, moved callback impls into cpp files.
Patch Set 5: Cleaned up namespace usage in cpp files.
Patch Set 6: Style review fixes
Patch Set 7: Reuploaded full diff
Patch Set 8: Bug fix for global references (shadowing)
Patch Set 9: TRY, abpEngine, statics
Patch Set 10: Added missing empty lines after file comments
Patch Set 11: Changed AppInfo to use builder pattern.
Patch Set 12: Removed TODO from AppInfo.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
jni/Android.mk
jni/JniCallbacks.h
jni/JniCallbacks.cpp
jni/JniEventCallback.cpp
jni/JniFilter.cpp
jni/JniFilterChangeCallback.cpp
jni/JniFilterEngine.cpp
jni/JniJsEngine.cpp
jni/JniJsValue.h
jni/JniJsValue.cpp
jni/JniLogSystem.cpp
jni/JniSubscription.cpp
jni/JniUpdaterCallback.cpp
jni/JniWebRequest.cpp
jni/Utils.h
jni/Utils.cpp
src/com/github/rjeschke/neetutils/Objects.java
src/com/github/rjeschke/neetutils/collections/Tuple.java
src/com/github/rjeschke/neetutils/dispose/Disposable.java
src/com/github/rjeschke/neetutils/dispose/Disposer.java
src/com/github/rjeschke/neetutils/dispose/ReferenceList.java
src/org/adblockplus/android/ABPEngine.java
src/org/adblockplus/android/JSEngine.java
src/org/adblockplus/libadblockplus/AdblockPlusException.java
src/org/adblockplus/libadblockplus/AppInfo.java
src/org/adblockplus/libadblockplus/EventCallback.java
src/org/adblockplus/libadblockplus/Filter.java
src/org/adblockplus/libadblockplus/FilterChangeCallback.java
src/org/adblockplus/libadblockplus/FilterEngine.java
src/org/adblockplus/libadblockplus/JniExceptionHandler.java
src/org/adblockplus/libadblockplus/JsEngine.java
src/org/adblockplus/libadblockplus/JsValue.java
src/org/adblockplus/libadblockplus/LogSystem.java
src/org/adblockplus/libadblockplus/ServerResponse.java
src/org/adblockplus/libadblockplus/Subscription.java
src/org/adblockplus/libadblockplus/UpdaterCallback.java
src/org/adblockplus/libadblockplus/WebRequest.java
Left:
Side by side diff
|
Download
Right:
Side by side diff
|
Download
« no previous file with change/comment
|
« src/org/adblockplus/android/ABPEngine.java
('k') |
src/org/adblockplus/libadblockplus/AdblockPlusException.java »
('j') |
no next file with change/comment »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
LEFT
RIGHT
LEFT
RIGHT
« src/org/adblockplus/android/ABPEngine.java
('k') |
src/org/adblockplus/libadblockplus/AdblockPlusException.java »
('j') |
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Toggle Comments
('s')
Edit Message
Issue 6606493159784448: New JNI bindings (Closed)
Created March 14, 2014, 11:32 a.m. by René Jeschke
Modified April 11, 2014, 1:49 p.m.
Reviewers: Felix Dahlke
Base URL:
Comments: 93
This is Rietveld