Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: src/org/adblockplus/libadblockplus/AppInfo.java

Issue 6606493159784448: New JNI bindings (Closed)
Left Patch Set: Changed AppInfo to use builder pattern. Created April 11, 2014, 1:26 p.m.
Right Patch Set: Removed TODO from AppInfo. Created April 11, 2014, 1:28 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2014 Eyeo GmbH 3 * Copyright (C) 2006-2014 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 package org.adblockplus.libadblockplus; 18 package org.adblockplus.libadblockplus;
19 19
20 public class AppInfo 20 public class AppInfo
21 { 21 {
22 public final String id; 22 public final String id;
23 public final String version; 23 public final String version;
24 public final String name; 24 public final String name;
25 public final String application; 25 public final String application;
26 public final String applicationVersion; 26 public final String applicationVersion;
27 public final String locale; 27 public final String locale;
28 public final boolean developmentBuild; 28 public final boolean developmentBuild;
29 29
30 // TODO: Builder or not?
31 private AppInfo(final String id, final String version, final String name, fina l String application, final String applicationVersion, 30 private AppInfo(final String id, final String version, final String name, fina l String application, final String applicationVersion,
32 final String locale, final boolean developmentBuild) 31 final String locale, final boolean developmentBuild)
33 { 32 {
34 this.id = id; 33 this.id = id;
35 this.version = version; 34 this.version = version;
36 this.name = name; 35 this.name = name;
37 this.application = application; 36 this.application = application;
38 this.applicationVersion = applicationVersion; 37 this.applicationVersion = applicationVersion;
39 this.locale = locale; 38 this.locale = locale;
40 this.developmentBuild = developmentBuild; 39 this.developmentBuild = developmentBuild;
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 this.developmentBuild = developmentBuild; 100 this.developmentBuild = developmentBuild;
102 return this; 101 return this;
103 } 102 }
104 103
105 public AppInfo build() 104 public AppInfo build()
106 { 105 {
107 return new AppInfo(this.id, this.version, this.name, this.application, thi s.applicationVersion, this.locale, this.developmentBuild); 106 return new AppInfo(this.id, this.version, this.name, this.application, thi s.applicationVersion, this.locale, this.developmentBuild);
108 } 107 }
109 } 108 }
110 } 109 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld