jni/JniCallbacks.cpp - Issue 6606493159784448: New JNI bindings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: jni/JniCallbacks.cpp

Issue 6606493159784448: New JNI bindings (Closed)

Left Patch Set: Style review fixes Created March 28, 2014, 11 a.m.

Right Patch Set: Removed TODO from AppInfo. Created April 11, 2014, 1:28 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 * This file is part of Adblock Plus <http://adblockplus.org/>,	2 * This file is part of Adblock Plus <http://adblockplus.org/>,

3 * Copyright (C) 2006-2014 Eyeo GmbH	3 * Copyright (C) 2006-2014 Eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 13 matching lines...) Expand all Loading...
24 exceptionLoggerClass.reset(new JniGlobalReference<jclass>(env, env->FindClass( PKG("JniExceptionHandler"))));	24 exceptionLoggerClass.reset(new JniGlobalReference<jclass>(env, env->FindClass( PKG("JniExceptionHandler"))));

25 }	25 }

26	26

27 JniCallbackBase::~JniCallbackBase()	27 JniCallbackBase::~JniCallbackBase()

28 {	28 {

29	29

30 }	30 }

31	31

32 void JniCallbackBase::LogException(JNIEnv* env, jthrowable throwable) const	32 void JniCallbackBase::LogException(JNIEnv* env, jthrowable throwable) const

33 {	33 {

34 jmethodID logMethod = env->GetStaticMethodID(exceptionLoggerClass->get(), "log Exception", "(Ljava/lang/Throwable;)V");	34 jmethodID logMethod = env->GetStaticMethodID(exceptionLoggerClass->Get(), "log Exception", "(Ljava/lang/Throwable;)V");

35 if (logMethod)	35 if (logMethod)

36 {	36 {

37 env->CallStaticVoidMethod(exceptionLoggerClass->get(), logMethod, throwable) ;	37 env->CallStaticVoidMethod(exceptionLoggerClass->Get(), logMethod, throwable) ;

38 }	38 }

39 }	39 }

40	40

41 void JniCallbackBase::CheckAndLogJavaException(JNIEnv* env) const	41 void JniCallbackBase::CheckAndLogJavaException(JNIEnv* env) const

42 {	42 {

43 if (env->ExceptionCheck())	43 if (env->ExceptionCheck())

44 {	44 {

45 jthrowable throwable = env->ExceptionOccurred();	45 jthrowable throwable = env->ExceptionOccurred();

46 env->ExceptionClear();	46 env->ExceptionClear();

47 LogException(env, throwable);	47 LogException(env, throwable);

48 }	48 }

49 }	49 }

LEFT	RIGHT