modules/private-stub/hiera/roles/codereviewserver.yaml - Issue 6651739155464192: Issue 2185 - Migrate Rieveld superuser creation to fixture

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: modules/private-stub/hiera/roles/codereviewserver.yaml

Issue 6651739155464192: Issue 2185 - Migrate Rieveld superuser creation to fixture (Closed)

Left Patch Set: Created March 20, 2015, 11:33 a.m.

Right Patch Set: Issue Issue 2185 - Migrate Rieveld superuser creation to fixture Created March 20, 2015, 12:48 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 rietveld_fixtures:	1 rietveld::fixtures:

2 development:	2 development:

3 ensure: "present"	3 ensure: "present"

4 source: "puppet:///modules/private/rietveld-auth-users.json"	4 source: "puppet:///modules/private/rietveld-auth-users.json"
	Felix Dahlke 2015/03/21 20:53:06 Can't we set this outisde private-stub? Seems a lo Can't we set this outisde private-stub? Seems a lot like this would be the same file/path for both develompent and production, the file contents make the difference. mathias 2015/03/21 23:47:26 Not only the contents of the file are specific to Show quoted text On 2015/03/21 20:53:06, Felix H. Dahlke wrote: > Can't we set this outisde private-stub? Seems a lot like this would be the same > file/path for both develompent and production, the file contents make the > difference. Not only the contents of the file are specific to the development environment - the very requirement for this fixture is specific as well. In other words: Outside private-stub, this snippet would introduce a non-required new requirement for any future use of the rietveld module. Sure, we'll probably do something similar in production, but that is only circumstantial anyway. It's quite possible, for example, that we decide to always have some test data set up in development (but of course not in production). That could be in another fixture. Or the same. It just does not matter when handled in private, and does not interfere with any requirement from any other environment. PS: One should think of module "private" as "environment", because that's actually what it is - environment-specific setup. The fact that we maintain our production environment data in a confidential repo is just unimporant for the Puppet logic. Also, one would not feel the need to justify the existence of the module if named slightly different.. ;-)
5	5

LEFT	RIGHT