Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6719238685327360: Issue 384 - Wrong image shows up briefly for Adblock Plus icon (Closed)

Created:
May 23, 2014, 11:05 a.m. by Wladimir Palant
Modified:
Jan. 7, 2016, 9:10 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 384 - Wrong image shows up briefly for Adblock Plus icon

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/content/ui/overlay.xul View 1 chunk +1 line, -1 line 0 comments Download
M lib/appSupport.js View 1 chunk +2 lines, -1 line 0 comments Download
M lib/ui.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2
Wladimir Palant
May 23, 2014, 11:06 a.m. (2014-05-23 11:06:12 UTC) #1
Thomas Greiner
May 23, 2014, 1:40 p.m. (2014-05-23 13:40:52 UTC) #2
Without the toolbarbutton-1 class our toolbar button looks different than any of
the native Firefox buttons and the buttons from other extensions in the toolbar.

While I do agree that it doesn't look bad without that class, I tend to stick
with consistency in this case and keep it.

Powered by Google App Engine
This is Rietveld