ext/common.js - Issue 6751260996796416: Issue 1724 - Fixed memory leak in messaging code, when no response is sent, on Safari

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: ext/common.js

Issue 6751260996796416: Issue 1724 - Fixed memory leak in messaging code, when no response is sent, on Safari (Closed)

Patch Set: Created Jan. 8, 2015, 2:14 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: ext/common.js

===================================================================

--- a/ext/common.js

+++ b/ext/common.js

@@ -20,10 +20,9 @@

{

window.ext = {};

- var EventTarget = ext._EventTarget = function(cancelable)

+ var EventTarget = ext._EventTarget = function()

{

this._listeners = [];

- this._cancelable = cancelable;

};

EventTarget.prototype = {

addListener: function(listener)

@@ -39,17 +38,12 @@

_dispatch: function()

{

- var result = null;

+ var results = [];

for (var i = 0; i < this._listeners.length; i++)

- {

- result = this._listeners[i].apply(null, arguments);

+ results.push(this._listeners[i].apply(null, arguments));

- if (this._cancelable && result === false)

- break;

- }

- return result;

+ return results;

}

};

})();