Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/survey.js

Issue 8382011: Applied changes from emailed code review (Closed)
Left Patch Set: Created Sept. 28, 2012, 12:52 p.m.
Right Patch Set: Created Sept. 28, 2012, 1:40 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lib/rules.js ('k') | lib/typedItCollector.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* This Source Code Form is subject to the terms of the Mozilla Public 1 /* This Source Code Form is subject to the terms of the Mozilla Public
2 * License, v. 2.0. If a copy of the MPL was not distributed with this file, 2 * License, v. 2.0. If a copy of the MPL was not distributed with this file,
3 * You can obtain one at http://mozilla.org/MPL/2.0/. */ 3 * You can obtain one at http://mozilla.org/MPL/2.0/. */
4 4
5 Cu.import("resource://gre/modules/Services.jsm"); 5 Cu.import("resource://gre/modules/Services.jsm");
6 6
7 let {Prefs} = require("prefs"); 7 let {Prefs} = require("prefs");
8 8
9 let surveyLang = null; 9 let surveyLang = null;
10 let surveyUrl = null; //"http://urlfixer.org/usersurvey/..."; 10 let surveyUrl = null; //"http://urlfixer.org/usersurvey/...";
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 { 71 {
72 openSurvey(); 72 openSurvey();
73 panel.hidePopup(); 73 panel.hidePopup();
74 }); 74 });
75 document.getElementById("url-fixer-cancel-button").addEventListener("command ", function() 75 document.getElementById("url-fixer-cancel-button").addEventListener("command ", function()
76 { 76 {
77 panel.hidePopup(); 77 panel.hidePopup();
78 }); 78 });
79 panel.addEventListener("popuphidden", function() 79 panel.addEventListener("popuphidden", function()
80 { 80 {
81 panel.parentNode.removeChild(panel); 81 panel.parentNode.removeChild(panel);
Wladimir Palant 2012/09/28 13:31:26 Please remove the style node as well.
82 style.parentNode.removeChild(style);
82 }); 83 });
83 84
84 let anchor = document.getElementById("identity-box"); 85 let anchor = document.getElementById("identity-box");
85 panel.openPopup(anchor, "after_start", 0, 0, false, true); 86 panel.openPopup(anchor, "after_start", 0, 0, false, true);
86 }, false); 87 }, false);
87 request.send(null); 88 request.send(null);
88 } 89 }
89 90
90 function openSurvey() 91 function openSurvey()
91 { 92 {
92 let window = Services.wm.getMostRecentWindow("navigator:browser"); 93 let window = Services.wm.getMostRecentWindow("navigator:browser");
93 if (window) 94 if (window)
94 { 95 {
95 let browser = require("appIntegration").getBrowser(window); 96 let browser = require("appIntegration").getBrowser(window);
96 browser.loadOneTab(surveyUrl + "&lang=" + surveyLang, { 97 browser.loadOneTab(surveyUrl + "&lang=" + surveyLang, {
97 referrerURI: Services.io.newURI("http://url.fixer/", null, null), 98 referrerURI: Services.io.newURI("http://url.fixer/", null, null),
98 inBackground: false 99 inBackground: false
99 }); 100 });
100 } 101 }
101 } 102 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld