Applied changes from emailed code review

lib/survey.js

 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this file,
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 Cu.import("resource://gre/modules/Services.jsm");
 
 let {Prefs} = require("prefs");
 
 let surveyLang = null;
 let surveyUrl = null; //"http://urlfixer.org/usersurvey/...";
@@ skipping 57 matching lines @@
     document.getElementById("mainPopupSet").appendChild(panel);
     document.getElementById("url-fixer-icon").setAttribute("src", require("info").addonRoot + "icon64.png");
     document.getElementById("url-fixer-accept-button").addEventListener("command", function()
     {
       openSurvey();
       panel.hidePopup();
     });
     document.getElementById("url-fixer-cancel-button").addEventListener("command", function()
     {
       panel.hidePopup();
     });

[Wladimir Palant, 2012/09/28 11:29:33]

Forgot to mention in the previous review: you shouldn't leave the pop-up around,
please clean up after yourself (e.g. in case the extension is updated - you
don't want the old styles still around). Attaching a "popuphidden" event
listener to the panel and removing the nodes from the document there should do.

+    panel.addEventListener("popuphidden", function()
+    {
+      panel.parentNode.removeChild(panel);
+      style.parentNode.removeChild(style);
+    });
 
     let anchor = document.getElementById("identity-box");
     panel.openPopup(anchor, "after_start", 0, 0, false, true);
   }, false);
   request.send(null);
 }
 
 function openSurvey()
 {
   let window = Services.wm.getMostRecentWindow("navigator:browser");
   if (window)
   {
     let browser = require("appIntegration").getBrowser(window);
     browser.loadOneTab(surveyUrl + "&lang=" + surveyLang, {
         referrerURI: Services.io.newURI("http://url.fixer/", null, null),
         inBackground: false
     });
   }
 }