Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: firstRun.html

Issue 8615139: adblockpluschrome: Open share page in lightbox (Closed)
Patch Set: Created Oct. 25, 2012, 1:29 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | firstRun.js » ('j') | firstRun.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: firstRun.html
===================================================================
--- a/firstRun.html
+++ b/firstRun.html
@@ -7,7 +7,6 @@
<link href="/skin/firstRun.css" type="text/css" rel="stylesheet" />
</head>
<body>
-
<h1 id="title">
<div id="title-main"></div>
<div id="title-changelog"><a class="i18n_firstRun_changelog"></a></div>
@@ -25,8 +24,8 @@
<div id="share1">
<p id="share-text1" class="i18n_firstRun_share1"></p>
<div id="share-images1">
- <a class="share-image share-facebook" target="_blank"></a>
- <a class="share-image share-twitter" target="_blank"></a>
+ <a class="share-image share-facebook" href="#" target="_blank"></a>
+ <a class="share-image share-twitter" href="#" target="_blank"></a>
</div>
</div>
@@ -35,10 +34,13 @@
<div id="share-images2">
<a id="share-donate" class="i18n_firstRun_share2_donate" target="_blank"></a>
<span id="share2-connection" class="i18n_firstRun_share2_or"></span>
- <a class="share-image share-facebook" target="_blank"></a>
- <a class="share-image share-twitter" target="_blank"></a>
- <div>
+ <a class="share-image share-facebook" href="#" target="_blank"></a>
+ <a class="share-image share-twitter" href="#" target="_blank"></a>
+ </div>
</div>
+ <div id="glass-pane">
+ <iframe id="share-popup" scrolling="no"></iframe>
+ </div>
</body>
</html>
« no previous file with comments | « no previous file | firstRun.js » ('j') | firstRun.js » ('J')

Powered by Google App Engine
This is Rietveld