Reports - user usefullness

sitescripts/reports/static/reports.js

 if (typeof localStorage == "undefined")
   window.localStorage = {};
 var templates;
 
 function migrateCookies()
 {
   var cookies = document.cookie.split(/\s*;\s*/);
   for (var i = 0; i < cookies.length; i++)
   {
     if (/^(.*?)=(.*)/.test(cookies[i]))
@@ skipping 11 matching lines @@
         document.cookie = encodeURIComponent(key) + "=;expires=Thu, 01-Jan-1970 00:00:01 GMT";
     }
   }
 }
 
 function escapeHTML(value)
 {
   return value.replace(/&/g, "&amp;").replace(/</g, "&lt;").replace(/>/g, "&gt;").replace(/"/g, "&quot;");
 }
 
+function setRadio(radio, value)
+{
+  for (i = 0; i < radio.length; i++)
+  {
+    if (radio[i].value == value)
+      radio[i].checked = true;
+    else
+      radio[i].checked = false;
+  }
+}
+
 function saveSecret(guid, secret)
 {
   var secrets = localStorage.secrets;
   if (secrets)
     secrets = JSON.parse(secrets);
   else
     secrets = {};
   secrets[guid] = {value: secret, expiration: new Date().getTime() + 1000*60*60*24*30};
   localStorage.secrets = JSON.stringify(secrets);
 }
 
 function setSecret(guid, secret)
 {
   saveSecret(guid, secret);
 
   var status = "";
   var statusCell = document.getElementById("statusCell");
   if (statusCell)
     status = statusCell.textContent;
+  
+  var utility = "0";
+  var utilityCell = document.getElementById("utilityCell");
 
   var div = document.createElement("div");
   div.className = "updateLink"
   var link = document.createElement("a");
   link.setAttribute("href", "javascript:void(0);");
   link.textContent = "Update status"
   div.appendChild(link);
 
   if (statusCell)
     statusCell.appendChild(div);
   else
     document.body.insertBefore(div, document.body.firstChild);
 
   link.onclick = function()
   {
     var notifyBox = "";
+    var utilityRadios = "";
     if (document.getElementById("emailCell"))
+    {
       notifyBox = '<span id="notifyField"><input type="checkbox" id="notify" name="notify" value="1" /> <label for="notify">Notify user</label></span>';
-
-    div.innerHTML = '<form action="/updateReport" method="POST">' +
+      utilityRadios = '<br />Utility: <input type="radio" name="utility" value="0" checked="checked" /> not established <input type="radio" name="utility" value="1" /> usefull <input type="radio" name="utility" value="-1" /> harmful';

[Wladimir Palant, 2012/10/18 15:41:24]

Not "harmful" but "useless". And it is "useful", not "usefull".

Also, shouldn't setting utilityRadios be dependent on utilityCell rather than
emailCell for consistency?

[Andrey Novikov, 2012/10/18 15:51:29]

Done.

+    }
+      
+    div.innerHTML = '<form id="updateForm" action="/updateReport" method="POST">' +
       '<input type="hidden" name="secret" value="' + escapeHTML(secret) + '" />' +
       '<input type="hidden" name="guid" value="' + escapeHTML(guid) + '" />' +
       '<p>' +
         'Status templates: <br />' +
         '<select id="templatesField"><option value="" selected="selected" disabled="true">(select one)</option></select>' +
       '</p>' +
       '<p>' +
         'Enter new status:' + notifyBox + '<br />' +
-        '<textarea id="statusField" name="status" oninput="updateTemplateButtons();"></textarea>' +
+        '<textarea id="statusField" name="status" oninput="updateTemplateButtons();"></textarea>' + 
+        utilityRadios +
       '</p>' +
       '<div>' +
         '<button id="addTemplateButton" type="button" onclick="addTemplate();">Add as template</button>' +
         '<button id="removeTemplateButton" type="button" onclick="removeTemplate();">Remove template</button>' +
         '<input type="submit" value="Change status"/>' +
       '</div>' +
     '</form>';
     document.getElementById("templatesField").addEventListener("change", function()
     {
       if (this.selectedIndex > 0)
       {
         document.getElementById("statusField").value = this.options[this.selectedIndex].value;
         var notifyField = document.getElementById("notify");
         if (notifyField)
           notifyField.checked = true;
         updateTemplateButtons();
       }
     }, false);
     var statusField = document.getElementById("statusField");
     statusField.value = status;
+    if (utilityCell)
+    {
+      utility = utilityCell.getAttribute("value");
+      setRadio(document.getElementById("updateForm").elements.utility, utility);
+    }
+
     updateTemplates();
     statusField.focus();
   }
 }
 
 function updateTemplates()
 {
   var templatesField = document.getElementById("templatesField");
   while (templatesField.options.length > 1)
     templatesField.remove(1);
@@ skipping 207 matching lines @@
       var spans = nodes[j].getElementsByTagName("span");
       for (var k = 0; k < spans.length; k++)
         if (spans[k].hasAttribute("title"))
           spans[k].setAttribute("title", toLocalDate(spans[k].getAttribute("title")));
     }
   }
 }
 
 window.addEventListener("DOMContentLoaded", initTables, false);
 window.addEventListener("DOMContentLoaded", changeDates, false);