Issue 8678083: Topic 11337: Image placeholders aren`t always hidden

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8678083: Topic 11337: Image placeholders aren`t always hidden (Closed)

Created:
Oct. 28, 2012, 4:48 p.m. by Wladimir Palant

Modified:
Oct. 30, 2012, 11:13 a.m.

Reviewers:
Thomas Greiner

Visibility:
Public.

Description

See https://adblockplus.org/forum/viewtopic.php?f=11&t=11337 for the context. It seems that Chrome sometimes initiates the network request long before the image element is added to the document, probably some kind of prefetching. This is a rather ugly work-around but it makes sure that whenever we fail to remove an image placeholder we will look for it again when other images need to be removed and when the document`s DOM is complete.

Patch Set 1 #

Created: Oct. 28, 2012, 4:48 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -10 lines)			Patch
	M	include.preload.js	View		1 chunk	+42 lines, -10 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages