Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: webrequest.js

Issue 8691076: Make sure to indicate to Chrome when our filters change (Closed)
Left Patch Set: Created Oct. 30, 2012, 9:51 a.m.
Right Patch Set: Created Oct. 30, 2012, 10:40 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of the Adblock Plus extension, 2 * This file is part of the Adblock Plus extension,
3 * Copyright (C) 2006-2012 Eyeo GmbH 3 * Copyright (C) 2006-2012 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 26 matching lines...) Expand all
37 'load': true 37 'load': true
38 }; 38 };
39 39
40 require("filterNotifier").FilterNotifier.addListener(function(action) 40 require("filterNotifier").FilterNotifier.addListener(function(action)
41 { 41 {
42 if (action in importantNotifications) 42 if (action in importantNotifications)
43 { 43 {
44 // Execute delayed to prevent multiple executions in a quick succession 44 // Execute delayed to prevent multiple executions in a quick succession
45 if (onFilterChangeTimeout != null) 45 if (onFilterChangeTimeout != null)
46 window.clearTimeout(onFilterChangeTimeout); 46 window.clearTimeout(onFilterChangeTimeout);
47 window.setTimeout(onFilterChange, 2000); 47 onFilterChangeTimeout = window.setTimeout(onFilterChange, 2000);
Thomas Greiner 2012/10/30 10:17:22 set onFilterChangeTimeout variable otherwise it wi
48 } 48 }
49 }); 49 });
50 50
51 var frames = {}; 51 var frames = {};
52 52
53 function onBeforeRequest(details) 53 function onBeforeRequest(details)
54 { 54 {
55 if (details.tabId == -1) 55 if (details.tabId == -1)
56 return {}; 56 return {};
57 57
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 { 199 {
200 var parentUrl = getFrameUrl(tabId, parent); 200 var parentUrl = getFrameUrl(tabId, parent);
201 if (parentUrl && isWhitelisted(parentUrl, type)) 201 if (parentUrl && isWhitelisted(parentUrl, type))
202 return true; 202 return true;
203 if (parentUrl && "keyException" in frames[tabId][frameId]) 203 if (parentUrl && "keyException" in frames[tabId][frameId])
204 return true; 204 return true;
205 parent = getFrameParent(tabId, parent); 205 parent = getFrameParent(tabId, parent);
206 } 206 }
207 return false; 207 return false;
208 } 208 }
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld