Encourage user to set email in issue reporter

chrome/content/ui/sendReport.js

 /*
  * This file is part of the Adblock Plus,
  * Copyright (C) 2006-2012 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 1305 matching lines @@
   textElement.abpInitialized = true;
 }
 
 function updateTypeWarningOverride()
 {
   document.documentElement.canAdvance = E("typeWarningOverride").checked;
 }
 
 function initScreenshotPage()
 {
+  document.documentElement.canAdvance = true;
+
   E("progressBar").activeItem = E("screenshotHeader");
 }
 
 function initCommentPage()
 {
   E("progressBar").activeItem = E("commentPageHeader");
 
+  updateEmail();
+  
   screenshotDataSource.exportData();
   updateDataField();
 }
 
 function showDataField()
 {
   E('dataDeck').selectedIndex = 1;
   updateDataField();
   E('data').focus();
 }
@@ skipping 29 matching lines @@
 
   let value = E("comment").value;
   appendElement(reportData.documentElement, "comment", null, value.substr(0, 1000));
   E("commentLengthWarning").setAttribute("visible", value.length > 1000);
   updateDataField();
 }
 
 function updateEmail()
 {
   removeReportElement("email");
-  appendElement(reportData.documentElement, "email", null, E("email").value.replace(/\@/g, " at ").replace(/\./g, " dot "));
+  
+  let anonymous = E("anonymousCheckbox").checked;
+  
+  if (anonymous)
+    E("email").value = "";

[Wladimir Palant, 2012/11/22 15:08:21]

Please don't do that, disabling it is sufficient - people might actually change
their mind.

[Andrey Novikov, 2012/11/23 06:32:16]

It will be not obvious that nothing will be sent if the text remains in the
field.

+  
+  let value = E("email").value;
+  E("email").setAttribute("value", value); // required for persist to work on textbox, see: https://bugzilla.mozilla.org/show_bug.cgi?id=111486

[Wladimir Palant, 2012/11/22 15:08:21]

Please put that comment on the line(s) before - we should at least *try* to
limit the line length to 80 characters. Plus, it makes the comment more visible.

[Andrey Novikov, 2012/11/23 06:32:16]

Done.

+
+  E("email").disabled = anonymous;
+  E("emailLabel").disabled = anonymous;
+  E("anonymityWarning").setAttribute("visible", anonymous);
+
+  if (!anonymous)
+    appendElement(reportData.documentElement, "email", null, value);
+
   updateDataField();
+
+  document.documentElement.canAdvance = anonymous || /\S/.test(value);
 }
 
 function updateExtensions(attach)
 {
   extensionsDataSource.exportData(attach);
   updateDataField();
 }
 
 function initSendPage()
 {
@@ skipping 145 matching lines @@
 
 function censorURL(url)
 {
   return url.replace(/([?;&\/#][^?;&\/#]+?=)[^?;&\/#]+/g, "$1*");
 }
 
 function encodeHTML(str)
 {
   return str.replace(/&/g, "&amp;").replace(/</g, "&lt;").replace(/>/g, "&gt;").replace(/"/g, "&quot;");
 }