Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: modules/base/manifests/init.pp

Issue 9351014: Add logrotate cronjob to all servers, don`t run logrotate unnecessarily on provisioning and use con… (Closed)
Left Patch Set: Created Feb. 7, 2013, 3:06 p.m.
Right Patch Set: Created Feb. 8, 2013, 8:19 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | modules/filterserver/files/logrotate » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 class base { 1 class base {
2 stage {'pre': before => Stage['main']} 2 stage {'pre': before => Stage['main']}
3 stage {'post': } 3 stage {'post': require => Stage['main']}
4 Stage['main'] -> Stage['post']
Felix Dahlke 2013/02/07 15:38:41 I'd like this to be consistent. So either this: {
5 4
6 class {'apt': 5 class {'apt':
7 stage => 'pre', 6 stage => 'pre',
8 always_apt_update => true 7 always_apt_update => true
9 } 8 }
10 9
11 class {'users': 10 class {'users':
12 stage => 'pre', 11 stage => 'pre',
13 } 12 }
14 13
15 include private::users, postfix 14 include private::users, postfix
16 15
17 package {['mercurial', 'vim', 'emacs']: ensure => present} 16 package {['mercurial', 'vim', 'emacs']: ensure => present}
18 17
19 file {'/etc/timezone': 18 file {'/etc/timezone':
20 ensure => file, 19 ensure => file,
21 owner => root, 20 owner => root,
22 group => root, 21 group => root,
23 mode => 0644, 22 mode => 0644,
24 source => 'puppet:///modules/base/timezone' 23 source => 'puppet:///modules/base/timezone'
25 } 24 }
26 25
27 class {'logrotate': 26 class {'logrotate':
28 stage => 'post' 27 stage => 'post'
29 } 28 }
30 } 29 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld