Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: sitescripts/logs/template/subscriptionOverview.html

Issue 9503001: Subscription stats: Make sure there can be no division by zero errors (Closed)
Patch Set: Fixed the issue in all the relevant places now Created March 1, 2013, 8:29 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 <!-- 1 <!--
2 - This file is part of the Adblock Plus web scripts, 2 - This file is part of the Adblock Plus web scripts,
3 - Copyright (C) 2006-2012 Eyeo GmbH 3 - Copyright (C) 2006-2012 Eyeo GmbH
4 - 4 -
5 - Adblock Plus is free software: you can redistribute it and/or modify 5 - Adblock Plus is free software: you can redistribute it and/or modify
6 - it under the terms of the GNU General Public License version 3 as 6 - it under the terms of the GNU General Public License version 3 as
7 - published by the Free Software Foundation. 7 - published by the Free Software Foundation.
8 - 8 -
9 - Adblock Plus is distributed in the hope that it will be useful, 9 - Adblock Plus is distributed in the hope that it will be useful,
10 - but WITHOUT ANY WARRANTY; without even the implied warranty of 10 - but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 24 matching lines...) Expand all
35 <tr> 35 <tr>
36 <td class="title" width="250">Last update:</td> 36 <td class="title" width="250">Last update:</td>
37 <td>{{now|formattime}}</td> 37 <td>{{now|formattime}}</td>
38 </tr> 38 </tr>
39 </table> 39 </table>
40 40
41 <div class="block_title">Monthly history</div> 41 <div class="block_title">Monthly history</div>
42 <div class="block"> 42 <div class="block">
43 <table align="center" style="margin-bottom: 20px;"> 43 <table align="center" style="margin-bottom: 20px;">
44 <tr align="bottom"> 44 <tr align="bottom">
45 {%- set maxHits, maxBandwidth = month|max(attribute='hits'), month|max (attribute='bandwidth') %} 45 {%- set maxHits = month|max(attribute='hits')|ensuremin(1) %}
46 {%- set totalHits = month|sum(attribute='hits') %} 46 {%- set maxBandwidth = month|max(attribute='bandwidth')|ensuremin(1) % }
47 {%- set totalBandwidth = month|sum(attribute='bandwidth') %} 47 {%- set totalHits = month|sum(attribute='hits')|ensuremin(1) %}
48 {%- set totalBandwidth = month|sum(attribute='bandwidth')|ensuremin(1) %}
48 {%- for info in month %} 49 {%- for info in month %}
49 <td align="center" style="vertical-align: bottom;"> 50 <td align="center" style="vertical-align: bottom;">
50 <div class="hitsChart vertical" title="Hits: {{info.hits}}" style="h eight: {{(info.hits / maxHits * 100)|round(method='ceil')|int}}px;"></div> 51 <div class="hitsChart vertical" title="Hits: {{info.hits}}" style="h eight: {{(info.hits / maxHits * 100)|round(method='ceil')|int}}px;"></div>
51 {{- '' -}} 52 {{- '' -}}
52 <div class="bandwidthChart vertical" title="Bandwidth: {{info.bandwi dth|bytes}}" style="height: {{(info.bandwidth / maxBandwidth * 100)|round(method ='ceil')|int}}px;"></div> 53 <div class="bandwidthChart vertical" title="Bandwidth: {{info.bandwi dth|bytes}}" style="height: {{(info.bandwidth / maxBandwidth * 100)|round(method ='ceil')|int}}px;"></div>
53 </td> 54 </td>
54 {%- endfor %} 55 {%- endfor %}
55 </tr> 56 </tr>
56 <tr> 57 <tr>
57 {%- for info in month %} 58 {%- for info in month %}
(...skipping 21 matching lines...) Expand all
79 <tr class="special"> 80 <tr class="special">
80 <td style="font-weight: bold">Total</td> 81 <td style="font-weight: bold">Total</td>
81 <td align="right">{{totalHits}}</td> 82 <td align="right">{{totalHits}}</td>
82 <td align="right">&nbsp;</td> 83 <td align="right">&nbsp;</td>
83 <td align="right">{{totalBandwidth|bytes}}</td> 84 <td align="right">{{totalBandwidth|bytes}}</td>
84 </tr> 85 </tr>
85 </table> 86 </table>
86 </div> 87 </div>
87 </body> 88 </body>
88 </html> 89 </html>
OLDNEW
« no previous file with comments | « sitescripts/logs/template/subscription.html ('k') | sitescripts/logs/template/subscriptionsMain.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld