Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: libadblockplus.gyp

Issue 9846017: Make JavaScript sources compile into the library; convert JavaScript files on the fly (Closed)
Left Patch Set: Created March 14, 2013, 10:02 p.m.
Right Patch Set: Review comments addressed Created March 15, 2013, 3:59 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lib/utils.js ('k') | shell/src/Main.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 { 1 {
2 'includes': ['third_party/v8/build/common.gypi', 2 'includes': ['third_party/v8/build/common.gypi',
3 'shell/shell.gyp'], 3 'shell/shell.gyp'],
4 'targets': [{ 4 'targets': [{
5 'target_name': 'libadblockplus', 5 'target_name': 'libadblockplus',
6 'type': '<(library)', 6 'type': '<(library)',
7 'include_dirs': [ 7 'include_dirs': [
8 'include', 8 'include',
9 'third_party/v8/include' 9 'third_party/v8/include'
10 ], 10 ],
11 'dependencies': ['third_party/v8/tools/gyp/v8.gyp:v8'], 11 'dependencies': ['third_party/v8/tools/gyp/v8.gyp:v8'],
12 'sources': [ 12 'sources': [
13 'src/ConsoleJsObject.cpp', 13 'src/ConsoleJsObject.cpp',
14 'src/ErrorCallback.cpp', 14 'src/ErrorCallback.cpp',
15 'src/FileReader.cpp', 15 'src/FileReader.cpp',
16 'src/JsEngine.cpp', 16 'src/JsEngine.cpp',
17 '<(INTERMEDIATE_DIR)/adblockplus.js.cc' 17 '<(INTERMEDIATE_DIR)/adblockplus.js.cc'
18 ], 18 ],
19 'direct_dependent_settings': { 19 'direct_dependent_settings': {
20 'include_dirs': ['include'] 20 'include_dirs': ['include']
21 }, 21 },
22 'export_dependent_settings': ['third_party/v8/tools/gyp/v8.gyp:v8'], 22 'export_dependent_settings': ['third_party/v8/tools/gyp/v8.gyp:v8'],
23 'actions': [{ 23 'actions': [{
24 'action_name': 'convert_js', 24 'action_name': 'convert_js',
25 'variables': { 25 'variables': {
26 'core_library_files': [ 26 'core_library_files': [
27 'lib/info.js',
28 'lib/io.js',
29 'lib/prefs.js',
30 'lib/utils.js',
31 'lib/elemHideHitRegistration.js',
27 'adblockplus/lib/filterNotifier.js', 32 'adblockplus/lib/filterNotifier.js',
28 'adblockplus/lib/filterClasses.js', 33 'adblockplus/lib/filterClasses.js',
29 'adblockplus/lib/subscriptionClasses.js', 34 'adblockplus/lib/subscriptionClasses.js',
30 'adblockplus/lib/filterStorage.js', 35 'adblockplus/lib/filterStorage.js',
31 'adblockplus/lib/elemHide.js', 36 'adblockplus/lib/elemHide.js',
32 'adblockplus/lib/matcher.js', 37 'adblockplus/lib/matcher.js',
33 'adblockplus/lib/filterListener.js', 38 'adblockplus/lib/filterListener.js',
34 'adblockplus/lib/synchronizer.js', 39 'adblockplus/lib/synchronizer.js',
35 ], 40 ],
36 'additional_library_files': [ 41 'additional_library_files': [
37 'lib/adblockplus_compat.js' 42 'lib/compat.js'
38 ], 43 ],
39 }, 44 },
40 'inputs': [ 45 'inputs': [
41 'convert_js.py', 46 'convert_js.py',
42 '<@(core_library_files)', 47 '<@(core_library_files)',
43 '<@(additional_library_files)', 48 '<@(additional_library_files)',
44 ], 49 ],
45 'outputs': [ 50 'outputs': [
46 '<(INTERMEDIATE_DIR)/adblockplus.js.cpp' 51 '<(INTERMEDIATE_DIR)/adblockplus.js.cpp'
47 ], 52 ],
(...skipping 13 matching lines...) Expand all
61 'dependencies': [ 66 'dependencies': [
62 'third_party/googletest.gyp:googletest_main', 67 'third_party/googletest.gyp:googletest_main',
63 'libadblockplus' 68 'libadblockplus'
64 ], 69 ],
65 'sources': [ 70 'sources': [
66 'test/ConsoleJsObject.cpp', 71 'test/ConsoleJsObject.cpp',
67 'test/JsEngine.cpp' 72 'test/JsEngine.cpp'
68 ] 73 ]
69 }] 74 }]
70 } 75 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld