Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(72)

Issue 10016005: Add API calls and stubs for filter matching and subscription management (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 7 months ago by Felix Dahlke
Modified:
6 years, 7 months ago
Visibility:
Public.

Patch Set 1 : #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -35 lines) Patch
M include/AdblockPlus.h View 1 chunk +1 line, -0 lines 0 comments Download
A include/AdblockPlus/FilterEngine.h View 1 chunk +34 lines, -0 lines 10 comments Download
M libadblockplus.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M shell/src/Command.h View 1 chunk +3 lines, -0 lines 0 comments Download
M shell/src/Command.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M shell/src/Main.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M shell/src/MatchesCommand.h View 1 chunk +6 lines, -1 line 0 comments Download
M shell/src/MatchesCommand.cpp View 2 chunks +21 lines, -2 lines 0 comments Download
M shell/src/SubscriptionsCommand.h View 1 chunk +4 lines, -3 lines 0 comments Download
M shell/src/SubscriptionsCommand.cpp View 3 chunks +58 lines, -25 lines 0 comments Download
A src/FilterEngine.cpp View 1 chunk +70 lines, -0 lines 0 comments Download
A test/FilterEngineStubs.cpp View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Felix Dahlke
6 years, 7 months ago (2013-04-03 12:43:57 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/10016005/diff/2001/include/AdblockPlus/FilterEngine.h File include/AdblockPlus/FilterEngine.h (right): http://codereview.adblockplus.org/10016005/diff/2001/include/AdblockPlus/FilterEngine.h#newcode11 include/AdblockPlus/FilterEngine.h:11: std::string title; We'll need to expose many more subscription ...
6 years, 7 months ago (2013-04-03 13:42:41 UTC) #2
Felix Dahlke
All valid points, some further detail below. Generally, my intention was to keep this as ...
6 years, 7 months ago (2013-04-04 05:10:51 UTC) #3
Wladimir Palant
On 2013/04/04 05:10:51, Felix H. Dahlke wrote: > Since Oleksandr has begun to integrate it ...
6 years, 7 months ago (2013-04-04 06:28:58 UTC) #4
Wladimir Palant
6 years, 7 months ago (2013-04-04 17:09:51 UTC) #5
I created http://codereview.adblockplus.org/10100009/ for my changes, this
review can be closed now.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5