Cross-platform thread primitives

src/Thread.cpp

 #include "Thread.h"
 
 using namespace AdblockPlus;
 
 namespace
 {
   void CallRun(Thread* thread)
   {
     thread->Run();
   }
 }
 
-Thread::Mutex::Mutex()
+Mutex::Mutex()
 {
 #ifdef WIN32
   InitializeCriticalSection(&nativeMutex);
 #else
   pthread_mutex_init(&nativeMutex, 0);
 #endif
 }
 
-Thread::Mutex::~Mutex()
+Mutex::~Mutex()
 {
-  Unlock();
 #ifdef WIN32
   DeleteCriticalSection(&nativeMutex);
 #else
   pthread_mutex_destroy(&nativeMutex);
 #endif
 }
 
-void Thread::Mutex::Lock()
+void Mutex::Lock()
 {
 #ifdef WIN32
   EnterCriticalSection(&nativeMutex);
 #else
   pthread_mutex_lock(&nativeMutex);
 #endif
 }
 
-void Thread::Mutex::Unlock()
+void Mutex::Unlock()
 {
 #ifdef WIN32
   LeaveCriticalSection(&nativeMutex);
 #else
   pthread_mutex_unlock(&nativeMutex);
 #endif
 }
 
-Thread::Condition::Condition()
+ConditionVariable::ConditionVariable()
 {
 #ifdef WIN32
   InitializeConditionVariable(&nativeCondition);
 #else
   pthread_cond_init(&nativeCondition, 0);
 #endif
 }
 
-Thread::Condition::~Condition()
+ConditionVariable::~ConditionVariable()
 {
 #ifndef WIN32
-  Signal();
   pthread_cond_destroy(&nativeCondition);
 #endif
 }
 
-void Thread::Condition::Wait(Thread::Mutex& mutex)
+void ConditionVariable::Wait(Mutex& mutex)
 {
 #ifdef WIN32
   SleepConditionVariableCS(&nativeCondition, &mutex.nativeMutex, INFINITE);
 #else
   pthread_cond_wait(&nativeCondition, &mutex.nativeMutex);
 #endif
 }
 
-void Thread::Condition::Signal()
+void ConditionVariable::Signal()
 {
 #ifdef WIN32
   WakeConditionVariable(&nativeCondition);
 #else
   pthread_cond_signal(&nativeCondition);
 #endif
 }
 
 Thread::~Thread()
 {
 }
 
 void Thread::Start()
 {
 #ifdef WIN32
-  thread = CreateThread(0, 0, (LPTHREAD_START_ROUTINE)&CallRun, this, 0, 0);
+  nativeThread = CreateThread(0, 0, (LPTHREAD_START_ROUTINE)&CallRun, this, 0, 0);
 #else
-  pthread_create(&thread, 0, (void *(*)(void*)) &CallRun, this);
+  pthread_create(&nativeThread, 0, (void *(*)(void*)) &CallRun, this);
 #endif
 }
 
 void Thread::Join()
 {
 #ifdef WIN32
-  WaitForSingleObject(thread, INFINITE);
+  WaitForSingleObject(nativeThread, INFINITE);
 #else
-  pthread_join(thread, 0);
+  pthread_join(nativeThread, 0);
 #endif
 }