src/GlobalJsObject.cpp - Issue 10169005: Windows specific changes. All tests passing on Windows.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/GlobalJsObject.cpp

Issue 10169005: Windows specific changes. All tests passing on Windows. (Closed)

Patch Set: Comments address. WIN32 in #ifdef and whitespace Created April 10, 2013, 7:55 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/GlobalJsObject.cpp

===================================================================

--- a/src/GlobalJsObject.cpp

+++ b/src/GlobalJsObject.cpp

@@ -50,7 +50,7 @@

Sleep(delay);

const v8::Locker locker(isolate);

const v8::HandleScope handleScope;

- v8::Handle<v8::Value> *argv = functionArguments.empty() ? 0 : &(functionArguments.front());

+ v8::Handle<v8::Value>* argv = functionArguments.empty() ? 0 : &(functionArguments.front());

function->Call(function, functionArguments.size(), argv);

delete this;

}

« no previous file with comments | « include/AdblockPlus/FilterEngine.h ('k') | no next file » | no next file with comments »