Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/GlobalJsObject.cpp

Issue 10169005: Windows specific changes. All tests passing on Windows. (Closed)
Patch Set: Previous patch comments addressed Created April 9, 2013, 7:38 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/FilterEngine.cpp ('K') | « src/FilterEngine.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/GlobalJsObject.cpp
===================================================================
--- a/src/GlobalJsObject.cpp
+++ b/src/GlobalJsObject.cpp
@@ -50,8 +50,8 @@
Sleep(delay);
const v8::Locker locker(isolate);
const v8::HandleScope handleScope;
- v8::Handle<v8::Value> argv = functionArguments.size() > 0 ? functionArguments[0] : v8::Handle<v8::Value>();
- function->Call(function, functionArguments.size(), &argv);
+ v8::Handle<v8::Value> *argv = functionArguments.empty() ? 0 : &(functionArguments.front());
Felix Dahlke 2013/04/09 08:11:15 Declaration type should be "v8::Handle<v8::Value>*
+ function->Call(function, functionArguments.size(), argv);
delete this;
}
« src/FilterEngine.cpp ('K') | « src/FilterEngine.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld