shell/src/GcCommand.cpp - Issue 10173031: Don`t use references to JsEngine to avoid use-after-free errors,switch to shared_ptr instead

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: shell/src/GcCommand.cpp

Issue 10173031: Don`t use references to JsEngine to avoid use-after-free errors,switch to shared_ptr instead (Closed)

Patch Set: Created April 18, 2013, 4:15 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 #include "GcCommand.h"	1 #include "GcCommand.h"

2	2

3 GcCommand::GcCommand(AdblockPlus::JsEngine& jsEngine)	3 GcCommand::GcCommand(AdblockPlus::JsEnginePtr jsEngine)

4 : Command("gc"), jsEngine(jsEngine)	4 : Command("gc"), jsEngine(jsEngine)

5 {	5 {

6 }	6 }

7	7

8 void GcCommand::operator()(const std::string& arguments)	8 void GcCommand::operator()(const std::string& arguments)

9 {	9 {

10 jsEngine.Gc();	10 jsEngine->Gc();

11 }	11 }

12	12

13 std::string GcCommand::GetDescription() const	13 std::string GcCommand::GetDescription() const

14 {	14 {

15 return "Initiates a garbage collection";	15 return "Initiates a garbage collection";

16 }	16 }

17	17

18 std::string GcCommand::GetUsage() const	18 std::string GcCommand::GetUsage() const

19 {	19 {

20 return name;	20 return name;

21 }	21 }

OLD	NEW