Side by Side Diff: src/AppInfoJsObject.h
Issue 10173031:
Don`t use references to JsEngine to avoid use-after-free errors,switch to shared_ptr instead (Closed)
Patch Set:
Created April 18, 2013, 4:15 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« shell/src/Main.cpp ('k')
|
src/AppInfoJsObject.cpp » ('j')
|
src/JsEngine.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 #ifndef ADBLOCK_PLUS_APP_INFO_JS_OBJECT_H | 1 #ifndef ADBLOCK_PLUS_APP_INFO_JS_OBJECT_H |
| 2 #define ADBLOCK_PLUS_APP_INFO_JS_OBJECT_H | 2 #define ADBLOCK_PLUS_APP_INFO_JS_OBJECT_H |
| 3 | 3 |
| 4 #include <v8.h> | 4 #include <v8.h> |
| 5 #include <AdblockPlus/JsEngine.h> | |
| 5 | 6 |
| 6 namespace AdblockPlus | 7 namespace AdblockPlus |
| 7 { | 8 { |
| 8 struct AppInfo; | 9 struct AppInfo; |
| 9 class ErrorCallback; | 10 class ErrorCallback; |
| 10 | 11 |
| 11 namespace AppInfoJsObject | 12 namespace AppInfoJsObject |
| 12 { | 13 { |
| 13 JsValuePtr Setup(JsEngine& jsEngine, const AppInfo& appInfo, JsValuePtr obj) ; | 14 JsValuePtr Setup(JsEnginePtr jsEngine, const AppInfo& appInfo, JsValuePtr ob j); |
| 14 } | 15 } |
| 15 } | 16 } |
| 16 | 17 |
| 17 #endif | 18 #endif |
| OLD | NEW |
« no previous file with comments
|
« shell/src/Main.cpp ('k')
|
src/AppInfoJsObject.cpp » ('j')
|
src/JsEngine.cpp » ('J')
