Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: src/ConsoleJsObject.h

Issue 10173031: Don`t use references to JsEngine to avoid use-after-free errors,switch to shared_ptr instead (Closed)
Patch Set: Created April 18, 2013, 4:15 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 #ifndef ADBLOCK_PLUS_CONSOLE_JS_OBJECT_H 1 #ifndef ADBLOCK_PLUS_CONSOLE_JS_OBJECT_H
2 #define ADBLOCK_PLUS_CONSOLE_JS_OBJECT_H 2 #define ADBLOCK_PLUS_CONSOLE_JS_OBJECT_H
3 3
4 #include <v8.h> 4 #include <v8.h>
5 #include <AdblockPlus/JsEngine.h>
5 6
6 namespace AdblockPlus 7 namespace AdblockPlus
7 { 8 {
8 class JsEngine; 9 class JsEngine;
9 10
10 namespace ConsoleJsObject 11 namespace ConsoleJsObject
11 { 12 {
12 JsValuePtr Setup(JsEngine& jsEngine, JsValuePtr obj); 13 JsValuePtr Setup(JsEnginePtr jsEngine, JsValuePtr obj);
13 } 14 }
14 } 15 }
15 16
16 #endif 17 #endif
OLDNEW
« no previous file with comments | « src/AppInfoJsObject.cpp ('k') | src/ConsoleJsObject.cpp » ('j') | src/JsEngine.cpp » ('J')

Powered by Google App Engine
This is Rietveld