Don`t use references to JsEngine to avoid use-after-free errors,switch to shared_ptr instead

src/JsValue.cpp

 #include <AdblockPlus.h>
 
 namespace
 {
   std::string fromV8String(v8::Handle<v8::Value> value)
   {
     v8::String::Utf8Value stringValue(value);
     if (stringValue.length())
       return std::string(*stringValue, stringValue.length());
     else
       return std::string();
   }
 
   v8::Local<v8::String> toV8String(const std::string& str)
   {
     return v8::String::New(str.c_str(), str.length());
   }
 }
 
-AdblockPlus::JsValue::JsValue(AdblockPlus::JsEngine& jsEngine,
+AdblockPlus::JsValue::JsValue(AdblockPlus::JsEnginePtr jsEngine,
       v8::Handle<v8::Value> value)
     : jsEngine(jsEngine),
-      value(v8::Persistent<v8::Value>::New(jsEngine.isolate, value))
+      value(v8::Persistent<v8::Value>::New(jsEngine->isolate, value))
 {
 }
 
 AdblockPlus::JsValue::~JsValue()
 {
-  value.Dispose(jsEngine.isolate);
+  value.Dispose(jsEngine->isolate);
 }
 
 bool AdblockPlus::JsValue::IsUndefined() const
 {
   const JsEngine::Context context(jsEngine);
   return value->IsUndefined();
 }
 
 bool AdblockPlus::JsValue::IsNull() const
 {
@@ skipping 145 matching lines @@
 AdblockPlus::JsValuePtr AdblockPlus::JsValue::Call(
     const JsValueList& params,
     AdblockPlus::JsValuePtr thisPtr) const
 {
   if (!IsFunction())
     throw new std::runtime_error("Attempting to call a non-function");
 
   const JsEngine::Context context(jsEngine);
 
   if (!thisPtr)
-    thisPtr = JsValuePtr(new JsValue(jsEngine, jsEngine.context->Global()));
+    thisPtr = JsValuePtr(new JsValue(jsEngine, jsEngine->context->Global()));
   if (!thisPtr->IsObject())
     throw new std::runtime_error("`this` pointer has to be an object");
   v8::Persistent<v8::Object> thisObj = v8::Persistent<v8::Object>::Cast(thisPtr->value);
 
   size_t argc = params.size();
   v8::Handle<v8::Value>* argv = new v8::Handle<v8::Value>[argc];
   for (size_t i = 0; i < argc; ++i)
     argv[i] = params[i]->value;
 
   const v8::TryCatch tryCatch;
   v8::Persistent<v8::Function> func = v8::Persistent<v8::Function>::Cast(value);
   v8::Local<v8::Value> result = func->Call(thisObj, argc, argv);
   delete argv;
 
   if (tryCatch.HasCaught())
     throw AdblockPlus::JsError(tryCatch.Exception(), tryCatch.Message());
 
   return JsValuePtr(new JsValue(jsEngine, result));
 }