Unified Diff: test/AppInfoJsObject.cpp
Issue 10173031:
Don`t use references to JsEngine to avoid use-after-free errors,switch to shared_ptr instead (Closed)
Patch Set:
Created April 18, 2013, 4:15 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« src/JsEngine.cpp ('K')
|
« src/WebRequestJsObject.cpp ('k')
|
test/ConsoleJsObject.cpp » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: test/AppInfoJsObject.cpp |
| =================================================================== |
| --- a/test/AppInfoJsObject.cpp |
| +++ b/test/AppInfoJsObject.cpp |
| @@ -3,14 +3,14 @@ |
| TEST(AppInfoJsObjectTest, AllProperties) |
| { |
| AdblockPlus::AppInfo appInfo; |
| appInfo.id = "1"; |
| appInfo.version = "2"; |
| appInfo.name = "4"; |
| appInfo.platform = "5"; |
| - AdblockPlus::JsEngine jsEngine(appInfo); |
| - ASSERT_EQ("1", jsEngine.Evaluate("_appInfo.id")->AsString()); |
| - ASSERT_EQ("2", jsEngine.Evaluate("_appInfo.version")->AsString()); |
| - ASSERT_EQ("4", jsEngine.Evaluate("_appInfo.name")->AsString()); |
| - ASSERT_EQ("5", jsEngine.Evaluate("_appInfo.platform")->AsString()); |
| + AdblockPlus::JsEnginePtr jsEngine(AdblockPlus::JsEngine::New(appInfo)); |
| + ASSERT_EQ("1", jsEngine->Evaluate("_appInfo.id")->AsString()); |
| + ASSERT_EQ("2", jsEngine->Evaluate("_appInfo.version")->AsString()); |
| + ASSERT_EQ("4", jsEngine->Evaluate("_appInfo.name")->AsString()); |
| + ASSERT_EQ("5", jsEngine->Evaluate("_appInfo.platform")->AsString()); |
| } |
« src/JsEngine.cpp ('K')
|
« src/WebRequestJsObject.cpp ('k')
|
test/ConsoleJsObject.cpp » ('j')
|
no next file with comments »
