Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/AppInfoJsObject.h

Issue 10173031: Don`t use references to JsEngine to avoid use-after-free errors,switch to shared_ptr instead (Closed)
Patch Set: Created April 18, 2013, 4:15 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/src/Main.cpp ('k') | src/AppInfoJsObject.cpp » ('j') | src/JsEngine.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/AppInfoJsObject.h
===================================================================
--- a/src/AppInfoJsObject.h
+++ b/src/AppInfoJsObject.h
@@ -1,17 +1,18 @@
#ifndef ADBLOCK_PLUS_APP_INFO_JS_OBJECT_H
#define ADBLOCK_PLUS_APP_INFO_JS_OBJECT_H
#include <v8.h>
+#include <AdblockPlus/JsEngine.h>
namespace AdblockPlus
{
struct AppInfo;
class ErrorCallback;
namespace AppInfoJsObject
{
- JsValuePtr Setup(JsEngine& jsEngine, const AppInfo& appInfo, JsValuePtr obj);
+ JsValuePtr Setup(JsEnginePtr jsEngine, const AppInfo& appInfo, JsValuePtr obj);
}
}
#endif
« no previous file with comments | « shell/src/Main.cpp ('k') | src/AppInfoJsObject.cpp » ('j') | src/JsEngine.cpp » ('J')

Powered by Google App Engine
This is Rietveld