Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: include/AdblockPlus/JsEngine.h

Issue 10184021: Some refactoring of global JavaScript objects (Closed)
Left Patch Set: Created April 15, 2013, 2:54 p.m.
Right Patch Set: Unbitrotted patch Created April 16, 2013, 3:32 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | include/AdblockPlus/JsValue.h » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 #ifndef ADBLOCKPLUS_JS_ENGINE_H 1 #ifndef ADBLOCKPLUS_JS_ENGINE_H
2 #define ADBLOCKPLUS_JS_ENGINE_H 2 #define ADBLOCKPLUS_JS_ENGINE_H
3 3
4 #include <stdexcept> 4 #include <stdexcept>
5 #include <string> 5 #include <string>
6 #include <v8.h> 6 #include <v8.h>
7 #include <AdblockPlus/JsValue.h> 7 #include <AdblockPlus/JsValue.h>
8 8
9 namespace AdblockPlus 9 namespace AdblockPlus
10 { 10 {
11 class FileSystem;
12 class WebRequest;
11 class ErrorCallback; 13 class ErrorCallback;
12 class FileReader;
13 class WebRequest;
14 14
15 class JsError : public std::runtime_error 15 class JsError : public std::runtime_error
16 { 16 {
17 public: 17 public:
18 explicit JsError(const v8::Handle<v8::Value> exception, 18 explicit JsError(const v8::Handle<v8::Value> exception,
19 const v8::Handle<v8::Message> message); 19 const v8::Handle<v8::Message> message);
20 }; 20 };
21 21
22 class JsEngine 22 class JsEngine
23 { 23 {
24 friend class JsValue; 24 friend class JsValue;
25 25
26 public: 26 public:
27 JsEngine(FileReader* const fileReader, 27 JsEngine(FileSystem* const fileReader,
28 WebRequest* const webRequest, 28 WebRequest* const webRequest,
29 ErrorCallback* const errorCallback); 29 ErrorCallback* const errorCallback);
30 JsValuePtr Evaluate(const std::string& source, 30 JsValuePtr Evaluate(const std::string& source,
31 const std::string& filename = ""); 31 const std::string& filename = "");
32 void Load(const std::string& scriptPath); 32 void Load(const std::string& scriptPath);
33 void Gc(); 33 void Gc();
34 JsValuePtr NewValue(const std::string& val); 34 JsValuePtr NewValue(const std::string& val);
35 JsValuePtr NewValue(int64_t val); 35 JsValuePtr NewValue(int64_t val);
36 JsValuePtr NewValue(bool val); 36 JsValuePtr NewValue(bool val);
37 inline JsValuePtr NewValue(const char* val) 37 inline JsValuePtr NewValue(const char* val)
38 { 38 {
39 return NewValue(std::string(val)); 39 return NewValue(std::string(val));
40 } 40 }
41 inline JsValuePtr NewValue(int val) 41 inline JsValuePtr NewValue(int val)
42 { 42 {
43 return NewValue((int64_t)val); 43 return NewValue((int64_t)val);
44 } 44 }
45 JsValuePtr NewObject(); 45 JsValuePtr NewObject();
46 static JsEngine& FromArguments(const v8::Arguments& arguments); 46 static JsEngine& FromArguments(const v8::Arguments& arguments);
47 JsValueList ConvertArguments(const v8::Arguments& arguments); 47 JsValueList ConvertArguments(const v8::Arguments& arguments);
48 48
49 inline FileReader& GetFileReader() 49 inline FileSystem& GetFileSystem()
50 { 50 {
51 return fileReader; 51 return fileSystem;
52 } 52 }
53 inline WebRequest& GetWebRequest() 53 inline WebRequest& GetWebRequest()
54 { 54 {
55 return webRequest; 55 return webRequest;
56 } 56 }
57 inline ErrorCallback& GetErrorCallback() 57 inline ErrorCallback& GetErrorCallback()
58 { 58 {
59 return errorCallback; 59 return errorCallback;
60 } 60 }
61 61
62 class Context 62 class Context
63 { 63 {
64 public: 64 public:
65 Context(const JsEngine& jsEngine); 65 Context(const JsEngine& jsEngine);
66 virtual inline ~Context() {}; 66 virtual inline ~Context() {};
67 67
68 private: 68 private:
69 const v8::Locker locker; 69 const v8::Locker locker;
70 const v8::HandleScope handleScope; 70 const v8::HandleScope handleScope;
71 const v8::Context::Scope contextScope; 71 const v8::Context::Scope contextScope;
72 }; 72 };
73 73
74 private: 74 private:
75 FileReader& fileReader; 75 FileSystem& fileSystem;
76 WebRequest& webRequest; 76 WebRequest& webRequest;
77 ErrorCallback& errorCallback; 77 ErrorCallback& errorCallback;
78 v8::Isolate* isolate; 78 v8::Isolate* isolate;
79 v8::Persistent<v8::Context> context; 79 v8::Persistent<v8::Context> context;
80 }; 80 };
81 } 81 }
82 82
83 #endif 83 #endif
LEFTRIGHT

Powered by Google App Engine
This is Rietveld