include/AdblockPlus/AppInfo.h - Issue 10198022: Pass application data into libadblockplus

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: include/AdblockPlus/AppInfo.h

Issue 10198022: Pass application data into libadblockplus (Closed)

Left Patch Set: Created April 12, 2013, 1:23 p.m.

Right Patch Set: Merged upstream, addressed issues, renamed AppInfo fields Created April 17, 2013, 2:47 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 #ifndef ADBLOCK_PLUS_APP_INFO_H	1 #ifndef ADBLOCK_PLUS_APP_INFO_H

2 #define ADBLOCK_PLUS_APP_INFO_H	2 #define ADBLOCK_PLUS_APP_INFO_H

3	3

4 #include <string>	4 #include <string>

5	5

6 namespace AdblockPlus	6 namespace AdblockPlus

7 {	7 {

8 struct AppInfo	8 struct AppInfo
Felix Dahlke 2013/04/12 13:32:27 I'm not happy with the property names here, sugges I'm not happy with the property names here, suggestions? I wanted to go with id, version, root and name, but that'd be inconsistent with application. Oleksandr 2013/04/12 14:14:52 Looks fine to me as it is. On 2013/04/12 13:32:27 Looks fine to me as it is. On 2013/04/12 13:32:27, Felix H. Dahlke wrote: Show quoted text > I'm not happy with the property names here, suggestions? I wanted to go with id, > version, root and name, but that'd be inconsistent with application.
9 {	9 {

10 std::string addonId;	10 std::string id;

11 std::string addonVersion;	11 std::string version;

12 std::string addonRoot;	12 std::string name;
Wladimir Palant 2013/04/15 10:56:00 addonRoot is probably unnecessary - it is only use addonRoot is probably unnecessary - it is only used in Firefox-specific code to retrieve files packaged with the extension (via XMLHttpRequest since this is actually a URL).
13 std::string addonName;	13 std::string platform;

14 std::string application;
Wladimir Palant 2013/04/15 10:56:00 application => platform? application => platform?
15 };	14 };

16 }	15 }

17	16

18 #endif	17 #endif

LEFT	RIGHT