Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Delta Between Two Patch Sets: lib/info.js
Issue
10198022
:
Pass application data into libadblockplus (Closed)
Left Patch Set:
Created April 12, 2013, 1:23 p.m.
Right Patch Set: Merged upstream, addressed issues, renamed AppInfo fields
Created April 17, 2013, 2:47 p.m.
Left:
Base
Patch Set 1:
Patch Set 2: Merged upstream, addressed issues, renamed AppInfo fields
Right:
Patch Set 1:
Patch Set 2: Merged upstream, addressed issues, renamed AppInfo fields
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
include/AdblockPlus.h
include/AdblockPlus/AppInfo.h
include/AdblockPlus/JsEngine.h
lib/info.js
libadblockplus.gyp
shell/src/Main.cpp
src/AppInfoJsObject.h
src/AppInfoJsObject.cpp
src/GlobalJsObject.h
src/GlobalJsObject.cpp
src/JsEngine.cpp
test/AppInfoJsObject.cpp
test/ConsoleJsObject.cpp
test/FileSystemJsObject.cpp
test/FilterEngineStubs.cpp
test/GlobalJsObject.cpp
test/JsEngine.cpp
test/JsValue.cpp
test/WebRequest.cpp
Left:
Side by side diff
|
Download
Right:
Side by side diff
|
Download
« no previous file with change/comment
|
« include/AdblockPlus/JsEngine.h
('k') |
libadblockplus.gyp »
('j') |
src/AppInfoJsObject.cpp »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
LEFT
RIGHT
1
exports.addonID = _appInfo.id;
2
exports.addonVersion = _appInfo.version;
3
exports.addonName = _appInfo.name;
4
exports.addonRoot = "";
5
exports.application = _appInfo.platform;
LEFT
RIGHT
« include/AdblockPlus/JsEngine.h
('k') |
libadblockplus.gyp »
('j') |
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Toggle Comments
('s')
Edit Message
Issue 10198022: Pass application data into libadblockplus (Closed)
Created April 12, 2013, 1:16 p.m. by Felix Dahlke
Modified April 18, 2013, 3:24 a.m.
Reviewers: Wladimir Palant, Oleksandr
Base URL:
Comments: 6
This is Rietveld