Make JsEngine::Evaluate() return a wrapper for v8::Value to accessdifferent variable types easily

test/JsEngine.cpp

 #include <AdblockPlus.h>
 #include <fstream>
 #include <gtest/gtest.h>
 #include <sstream>
 
 class ThrowingFileReader : public AdblockPlus::FileReader
 {
 public:
   std::auto_ptr<std::istream> Read(const std::string& path) const
   {
@@ skipping 32 matching lines @@
   }
 };
 
 TEST(JsEngineTest, EvaluateAndCall)
 {
   ThrowingFileReader fileReader;
   ThrowingErrorCallback errorCallback;
   AdblockPlus::JsEngine jsEngine(&fileReader, 0, &errorCallback);
   const std::string source = "function hello() { return 'Hello'; }";
   jsEngine.Evaluate(source);
-  const std::string result = jsEngine.Evaluate("hello()");
-  ASSERT_EQ("Hello", result);
+  AdblockPlus::JsValuePtr result = jsEngine.Evaluate("hello()");
+  ASSERT_TRUE(result->IsString());
+  ASSERT_EQ("Hello", result->AsString());
 }
 
 TEST(JsEngineTest, LoadAndCall)
 {
   StubFileReader fileReader;
   ThrowingErrorCallback errorCallback;
   AdblockPlus::JsEngine jsEngine(&fileReader, 0, &errorCallback);
   jsEngine.Load("hello.js");
-  const std::string result = jsEngine.Evaluate("hello()");
-  ASSERT_EQ("Hello", result);
+  AdblockPlus::JsValuePtr result = jsEngine.Evaluate("hello()");
+  ASSERT_TRUE(result->IsString());
+  ASSERT_EQ("Hello", result->AsString());
 }
 
 TEST(JsEngineTest, LoadBadStreamFails)
 {
   BadFileReader fileReader;
   ThrowingErrorCallback errorCallback;
   AdblockPlus::JsEngine jsEngine(&fileReader, 0, &errorCallback);
   ASSERT_ANY_THROW(jsEngine.Load("hello.js"));
 }
 
 TEST(JsEngineTest, RuntimeExceptionIsThrown)
 {
   ThrowingFileReader fileReader;
   ThrowingErrorCallback errorCallback;
   AdblockPlus::JsEngine jsEngine(&fileReader, 0, &errorCallback);
   ASSERT_THROW(jsEngine.Evaluate("doesnotexist()"), AdblockPlus::JsError);
 }
 
 TEST(JsEngineTest, CompileTimeExceptionIsThrown)
 {
   ThrowingFileReader fileReader;
   ThrowingErrorCallback errorCallback;
   AdblockPlus::JsEngine jsEngine(&fileReader, 0, &errorCallback);
   ASSERT_THROW(jsEngine.Evaluate("'foo'bar'"), AdblockPlus::JsError);
 }
+
+TEST(JsEngineTest, ValueCreation)
+{
+  ThrowingErrorCallback errorCallback;
+  AdblockPlus::JsEngine jsEngine(0, 0, &errorCallback);
+  AdblockPlus::JsValuePtr value;
+
+  value = jsEngine.NewValue("foo");
+  ASSERT_TRUE(value->IsString());
+  ASSERT_EQ("foo", value->AsString());
+
+  value = jsEngine.NewValue(12);
+  ASSERT_TRUE(value->IsNumber());
+  ASSERT_EQ(12, value->AsInt());
+
+  value = jsEngine.NewValue(true);
+  ASSERT_TRUE(value->IsBool());
+  ASSERT_TRUE(value->AsBool());
+}