Make JsEngine::Evaluate() return a wrapper for v8::Value to accessdifferent variable types easily

src/FilterEngine.cpp

 #include <algorithm>
 #include <cctype>
 #include <functional>
 
 #include <AdblockPlus.h>
 
 using namespace AdblockPlus;
 
 #if !FILTER_ENGINE_STUBS
 extern const char* jsSources[];
@@ skipping 91 matching lines @@
   if (text.find("!") == 0)
     type = TYPE_COMMENT;
   else if (text.find("@@") == 0)
     type = TYPE_EXCEPTION;
   else if (text.find("#@") != std::string::npos)
     type = TYPE_ELEMHIDE_EXCEPTION;
   else if (text.find("#") != std::string::npos)
     type = TYPE_ELEMHIDE;
   else
     type = TYPE_BLOCKING;
-  SetProperty("type", (int64_t)type);
+  SetProperty("type", type);
 }
 #else
 Filter::Filter(JsValuePtr value)
     : JsObject(value)
 {
   // Hack: set `type` property according to class name
   std::string className = GetClassName();
   Type type;
   if (className == "BlockingFilter")
     type = TYPE_BLOCKING;
   else if (className == "WhitelistFilter")
     type = TYPE_EXCEPTION;
   else if (className == "ElemHideFilter")
     type = TYPE_ELEMHIDE;
   else if (className == "ElemHideException")
     type = TYPE_ELEMHIDE_EXCEPTION;
   else if (className == "CommentFilter")
     type = TYPE_COMMENT;
   else
     type = TYPE_INVALID;
-  SetProperty("type", (int64_t)type);
+  SetProperty("type", type);
 }
 #endif
 
 bool Filter::IsListed()
 {
 #if FILTER_ENGINE_STUBS
   for (std::vector<FilterPtr>::iterator it = filterEngine.listedFilters.begin();
        it != filterEngine.listedFilters.end(); ++it)
   {
     if (it->get() == this)
@@ skipping 103 matching lines @@
 #else
   JsValuePtr func = jsEngine.Evaluate("API.removeSubscriptionFromList");
   JsValueList params;
   params.push_back(shared_from_this());
   func->Call(params);
 #endif
 }
 
 void Subscription::UpdateFilters()
 {
+#if !FILTER_ENGINE_STUBS
+  JsValuePtr func = jsEngine.Evaluate("API.updateSubscription");
+  JsValueList params;
+  params.push_back(shared_from_this());
+  func->Call(params);
+#endif
+}
+
+bool Subscription::IsUpdating()
+{
+#if FILTER_ENGINE_STUBS
+  return false;
+#else
+  JsValuePtr func = jsEngine.Evaluate("API.isSubscriptionUpdating");
+  JsValueList params;
+  params.push_back(shared_from_this());
+  JsValuePtr result = func->Call(params);
+  return result->AsBool();
+#endif
 }
 
 bool Subscription::operator==(const Subscription& subscription) const
 {
   return GetProperty("url", "") == subscription.GetProperty("url", "");
 }
 
 FilterEngine::FilterEngine(JsEngine& jsEngine) : jsEngine(jsEngine)
 {
 #if !FILTER_ENGINE_STUBS
@@ skipping 130 matching lines @@
   JsValuePtr func = jsEngine.Evaluate("API.getElementHidingSelectors");
   JsValueList params;
   params.push_back(jsEngine.NewValue(domain));
   JsValueList result = func->Call(params)->AsList();
   std::vector<std::string> selectors;
   for (JsValueList::iterator it = result.begin(); it != result.end(); ++it)
     selectors.push_back((*it)->AsString());
   return selectors;
 #endif
 }