shell/src/FiltersCommand.cpp - Issue 10213003: Make JsEngine::Evaluate() return a wrapper for v8::Value to accessdifferent variable types easily

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: shell/src/FiltersCommand.cpp

Issue 10213003: Make JsEngine::Evaluate() return a wrapper for v8::Value to accessdifferent variable types easily (Closed)

Patch Set: Unbitrotted patch Created April 16, 2013, 3:30 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: shell/src/FiltersCommand.cpp

===================================================================

--- a/shell/src/FiltersCommand.cpp

+++ b/shell/src/FiltersCommand.cpp

@@ -8,17 +8,17 @@ namespace

typedef std::vector<AdblockPlus::FilterPtr> FilterList;

void ShowFilterList(const FilterList& filters)

{

for (FilterList::const_iterator it = filters.begin();

it != filters.end(); it++)

{

std::string type;

- switch ((*it)->GetProperty("type", -1))

+ switch ((*it)->GetProperty("type", (int64_t)-1))

{

case AdblockPlus::Filter::TYPE_BLOCKING:

type = "blocking";

break;

case AdblockPlus::Filter::TYPE_EXCEPTION:

type = "exception";

break;

case AdblockPlus::Filter::TYPE_ELEMHIDE:

« no previous file with comments | « libadblockplus.gyp ('k') | src/FilterEngine.cpp » ('j') | no next file with comments »