Unified Diff: shell/src/FiltersCommand.cpp
Issue 10213003:
Make JsEngine::Evaluate() return a wrapper for v8::Value to accessdifferent variable types easily (Closed)
Patch Set: Added tests, resolved type conversion ambiguities, implemented some missing API calls
Created April 15, 2013, 6:23 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« include/AdblockPlus/JsValue.h ('K')
|
« libadblockplus.gyp ('k')
|
src/FilterEngine.cpp » ('j')
|
src/FilterEngine.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: shell/src/FiltersCommand.cpp |
| =================================================================== |
| --- a/shell/src/FiltersCommand.cpp |
| +++ b/shell/src/FiltersCommand.cpp |
| @@ -8,17 +8,17 @@ namespace |
| typedef std::vector<AdblockPlus::FilterPtr> FilterList; |
| void ShowFilterList(const FilterList& filters) |
| { |
| for (FilterList::const_iterator it = filters.begin(); |
| it != filters.end(); it++) |
| { |
| std::string type; |
| - switch ((*it)->GetProperty("type", -1)) |
| + switch ((*it)->GetProperty("type", (int64_t)-1)) |
|
Felix Dahlke
2013/04/16 15:14:33
This shouldn't be necessary, since there's a GetPr
|
| { |
| case AdblockPlus::Filter::TYPE_BLOCKING: |
| type = "blocking"; |
| break; |
| case AdblockPlus::Filter::TYPE_EXCEPTION: |
| type = "exception"; |
| break; |
| case AdblockPlus::Filter::TYPE_ELEMHIDE: |
« include/AdblockPlus/JsValue.h ('K')
|
« libadblockplus.gyp ('k')
|
src/FilterEngine.cpp » ('j')
|
src/FilterEngine.cpp » ('J')
