Android build target for libadblockplus

libadblockplus.gyp

 {
   'conditions': [[
     # We don't want to use curl on Windows, skip the check there
     'OS=="win"',
     {
       'variables': {
         'have_curl': 0
       }
     },
     {
       'variables': {
         'have_curl': '<!(python check_curl.py)'
       }
     }
   ]],
   'includes': ['third_party/v8/build/common.gypi',
                'shell/shell.gyp'],
   'targets': [{
     'target_name': 'libadblockplus',
     'type': '<(library)',
     'include_dirs': [
       'include',
       'third_party/v8/include'
     ],
-    'dependencies': ['third_party/v8/tools/gyp/v8.gyp:v8'],
+    'dependencies': [],

[Wladimir Palant, 2013/05/07 08:18:54]

You can simply remove that entry, having an empty list here is pointless.

+    'conditions': [
+      ['OS!="android"', {
+        'dependencies': ['third_party/v8/tools/gyp/v8.gyp:v8'],

[Eric, 2013/06/12 14:48:17]

I am curious as to why this dependency is needed for android but not the other
platforms. Any insight?

[Wladimir Palant, 2013/06/12 19:33:23]

It's actually the other way round. For Android we have to build V8 separately
and merely use the already compiled libs here because V8 uses a huge makefile
for the build that calls gyp as the last step. To build V8 along with our code
we would need to duplicate everything in that makefile which is clearly not a
good idea.

+      }]
+    ],
     'sources': [
       'src/AppInfoJsObject.cpp',
       'src/ConsoleJsObject.cpp',
       'src/DefaultErrorCallback.cpp',
       'src/DefaultFileSystem.cpp',
       'src/ErrorCallback.cpp',
       'src/FileSystemJsObject.cpp',
       'src/FilterEngine.cpp',
       'src/GlobalJsObject.cpp',
       'src/JsEngine.cpp',
       'src/JsValue.cpp',
       'src/Thread.cpp',
       'src/Utils.cpp',
       'src/WebRequestJsObject.cpp',
       '<(INTERMEDIATE_DIR)/adblockplus.js.cpp'
     ],
     'direct_dependent_settings': {
       'include_dirs': ['include']
     },
-    'export_dependent_settings': ['third_party/v8/tools/gyp/v8.gyp:v8'],
+    'export_dependent_settings': [],

[Wladimir Palant, 2013/05/07 08:18:54]

You can simply remove that entry, having an empty list here is pointless.

+    'conditions': [
+      ['OS!="android"', {
+        'export_dependent_settings': ['third_party/v8/tools/gyp/v8.gyp:v8'],
+      }]
+    ],
     'conditions': [
       ['have_curl==1',
         {
           'sources': [
             'src/DefaultWebRequestCurl.cpp',
           ],
           'link_settings': {
             'libraries': ['-lcurl']
           },
           'all_dependent_settings': {
@@ skipping 84 matching lines @@
       'test/WebRequest.cpp'
     ],
     'msvs_settings': {
       'VCLinkerTool': {
         'SubSystem': '1',   # Console
         'EntryPointSymbol': 'mainCRTStartup',
       },
     },
   }]
 }