Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: common.gypi

Issue 10228016: Android build target for libadblockplus (Closed)
Patch Set: Created April 30, 2013, 7:40 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: common.gypi
===================================================================
--- a/common.gypi
+++ b/common.gypi
@@ -19,6 +19,30 @@
'ldflags': [ '-pthread', ],
},
}],
+ ['OS=="android"', {
+ 'target_defaults': {
+ 'cflags': ['-std=gnu++0x', '-fexceptions', '-frtti'],
Andrey Novikov 2013/04/30 20:16:05 May be we need other flags, I do not know, I only
+ 'cflags!': [
+ '-pthread', # Not supported by Android toolchain.
+ ],
+ 'ldflags!': [
+ '-pthread', # Not supported by Android toolchain.
+ ],
+ 'include_dirs': [
+ 'include',
+ 'third_party/v8/include',
+ 'third_party/googletest/',
+ 'third_party/googletest/include',
+ 'third_party/googletest/include/internal'
Wladimir Palant 2013/05/07 08:18:54 Is it really necessary to list include directories
+ ],
+ 'link_settings': {
+ 'libraries': [
+ 'android_arm.release/obj.target/tools/gyp/libv8_base.a',
+ 'android_arm.release/obj.target/tools/gyp/libv8_snapshot.a',
Wladimir Palant 2013/05/07 08:18:54 These should only be relevant for the libadblockpl
+ ],
+ },
+ },
+ }],
],
'target_defaults': {

Powered by Google App Engine
This is Rietveld