Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: createsolution.bat
Issue
10234088
:
Use GYP to generate MSVS project files (Closed)
Patch Set: Tests passing now
Created April 24, 2013, 10:37 a.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Tests passing now
Patch Set 3: Moved project files to build/
Right:
Patch Set 1: None
Patch Set 2: Tests passing now
Patch Set 3: Moved project files to build/
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
buildmsvs.bat
buildmsvs_release.bat
common.gypi
createsolution.bat
libadblockplus.gyp
msvs_makesnapshot.bat
msvs_makesnapshot_release.bat
test/WebRequest.cpp
third_party/googletest.gyp
View unified diff
|
Download patch
« no previous file with comments
|
« common.gypi
('k') |
libadblockplus.gyp »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
@echo off
2
pushd %~dp0
3
third_party\gyp\gyp.bat --depth=. -f msvs -I common.gypi -Dtarget_arch=x64 libad blockplus.gyp
OLD
NEW
« no previous file with comments
|
« common.gypi
('k') |
libadblockplus.gyp »
('j') |
no next file with comments »
Edit Message
Issue 10234088: Use GYP to generate MSVS project files (Closed)
Created April 23, 2013, 4:24 p.m. by Wladimir Palant
Modified April 24, 2013, 2:51 p.m.
Reviewers: Felix Dahlke, Oleksandr, Eric
Base URL:
Comments: 16
This is Rietveld